[lttng-dev] [PATCH lttng-tools 2/2] Skip closed session on viewer listing

[Jérémie Galarneau]

Merged in master, stable-2.11, stable-2.10, and stable-2.9.

Thanks,
Jérémie

On Fri, Sep 07, 2018 at 03:18:38PM -0400, Jonathan Rajotte wrote:
> There is no value in listing a closed session. A viewer cannot hook itself
> to a closed session in live mode and the session is about to be removed from the
> sessions hash table.
> 
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien at efficios.com>
> ---
>  src/bin/lttng-relayd/live.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c
> index bc0e4529a..0fd41f1a8 100644
> --- a/src/bin/lttng-relayd/live.c
> +++ b/src/bin/lttng-relayd/live.c
> @@ -835,6 +835,11 @@ int viewer_list_sessions(struct relay_connection *conn)
>  
>  		health_code_update();
>  
> +		if (session->connection_closed) {
> +			/* Skip closed session */
> +			continue;
> +		}
> +
>  		if (count >= buf_count) {
>  			struct lttng_viewer_session *newbuf;
>  			uint32_t new_buf_count = buf_count << 1;
> -- 
> 2.17.1
>