[lttng-dev] [PATCH lttng-tools 2/2] Skip closed session on viewer listing

Jonathan Rajotte jonathan.rajotte-julien at efficios.com
Fri Sep 7 15:18:38 EDT 2018


There is no value in listing a closed session. A viewer cannot hook itself
to a closed session in live mode and the session is about to be removed from the
sessions hash table.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien at efficios.com>
---
 src/bin/lttng-relayd/live.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c
index bc0e4529a..0fd41f1a8 100644
--- a/src/bin/lttng-relayd/live.c
+++ b/src/bin/lttng-relayd/live.c
@@ -835,6 +835,11 @@ int viewer_list_sessions(struct relay_connection *conn)
 
 		health_code_update();
 
+		if (session->connection_closed) {
+			/* Skip closed session */
+			continue;
+		}
+
 		if (count >= buf_count) {
 			struct lttng_viewer_session *newbuf;
 			uint32_t new_buf_count = buf_count << 1;
-- 
2.17.1



More information about the lttng-dev mailing list