[lttng-dev] [PATCH lttng-tools 1/2] Fix: use LTTNG_VIEWER_ATTACH_UNK to report a closed session

Jérémie Galarneau jeremie.galarneau at efficios.com
Wed Sep 19 11:54:24 EDT 2018


Merged in master, stable-2.11, stable-2.10, and stable-2.9.

Thanks,
Jérémie

On Fri, Sep 07, 2018 at 03:18:37PM -0400, Jonathan Rajotte wrote:
> LTTNG_VIEWER_NEW_STREAMS_HUP is not a valid error number for the
> LTTNG_VIEWER_ATTACH_SESSION command. This result in erroneous error
> reporting on the client side.
> 
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien at efficios.com>
> ---
>  src/bin/lttng-relayd/live.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c
> index 6f50afc6c..bc0e4529a 100644
> --- a/src/bin/lttng-relayd/live.c
> +++ b/src/bin/lttng-relayd/live.c
> @@ -1089,7 +1089,7 @@ int viewer_attach_session(struct relay_connection *conn)
>  	if (closed) {
>  		send_streams = 0;
>  		response.streams_count = 0;
> -		response.status = htobe32(LTTNG_VIEWER_NEW_STREAMS_HUP);
> +		response.status = htobe32(LTTNG_VIEWER_ATTACH_UNK);
>  		goto send_reply;
>  	}
>  
> -- 
> 2.17.1
> 


More information about the lttng-dev mailing list