[lttng-dev] Fwd: VERY EASY one-liner fix to LTTng

[Mathieu Desnoyers]

Hi Marcus, 

I tried applying your patch, which was oddly formatted. Please try using "quilt" or "git" next time (or if you really want to generate your patch by hand, you need to use diff -urN). 

I re-wrote the patch to ensure the empty brackets are on the next line (similar to the surrounding lines), with a space in between (coding style), and ends with a comma (coding style). 

Next time, please provide the compiler version and compile flags you use to reproduce the issue. 

Fix merged into master, stable 2.3, stable 2.2, 

Thanks for reporting this problem, 

Mathieu 

----- Original Message -----

> From: "Marcus Tomlinson" <themarcustomlinson at gmail.com>
> To: lttng-dev at lists.lttng.org
> Sent: Wednesday, October 30, 2013 3:08:00 AM
> Subject: [lttng-dev] Fwd: VERY EASY one-liner fix to LTTng

> Hi again, so to make things a little easier than easy, here is a patch
> that’ll do the trick.
> If anyone manages to find some time to get this committed, please could you
> let me know.
> Thanks again!

> Begin forwarded message:

> > From: Marcus Tomlinson < themarcustomlinson at gmail.com >
> 
> > Subject: VERY EASY one-liner fix to LTTng
> 
> > Date: 29 October 2013 at 3:45:53 PM SAST
> 
> > To: lttng-dev at lists.lttng.org
> 

> > Hi, could I ask that somebody please make a VERY EASY fix to LTTng and push
> > it for me.
> 

> > I get compiler warnings about a missing initialiser for member ‘padding’ in
> > tracepoint.
> 
> > Removing these warnings is really simple:
> 

> > line 252 of “tracepoint.h” needs to change from:
> 
> > _TP_EXTRACT_STRING(_args), \
> 
> > to:
> 
> > _TP_EXTRACT_STRING(_args), {} \
> 

> > Thanks in advance!
> 

> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers 
EfficiOS Inc. 
http://www.efficios.com 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20131031/5addcfe6/attachment.html>