<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div>Hi Marcus,<br></div><div><br></div><div>I tried applying your patch, which was oddly formatted. Please try using "quilt" or "git" next time (or if you really want to generate your patch by hand, you need to use diff -urN).<br></div><div><br></div><div>I re-wrote the patch to ensure the empty brackets are on the next line (similar to the surrounding lines), with a space in between (coding style), and ends with a comma (coding style).<br></div><div><br></div><div>Next time, please provide the compiler version and compile flags you use to reproduce the issue.<br></div><div><br></div><div>Fix merged into master, stable 2.3, stable 2.2,<br></div><div><br></div><div>Thanks for reporting this problem,<br></div><div><br></div><div>Mathieu<br></div><div><br></div><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Marcus Tomlinson" <themarcustomlinson@gmail.com><br><b>To: </b>lttng-dev@lists.lttng.org<br><b>Sent: </b>Wednesday, October 30, 2013 3:08:00 AM<br><b>Subject: </b>[lttng-dev] Fwd: VERY EASY one-liner fix to LTTng<br><div><br></div><div>Hi again, so to make things a little easier than easy, here is a patch that’ll do the trick.</div><div>If anyone manages to find some time to get this committed, please could you let me know.</div><div>Thanks again!</div><div><br></div><br><div><br></div><div><br><div>Begin forwarded message:</div><br class="Apple-interchange-newline"><blockquote><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; color:;"><b>From: </b></span><span style="font-family:'Helvetica';">Marcus Tomlinson <<a href="mailto:themarcustomlinson@gmail.com" target="_blank">themarcustomlinson@gmail.com</a>><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; color:;"><b>Subject: </b></span><span style="font-family:'Helvetica';"><b>VERY EASY one-liner fix to LTTng</b><br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; color:;"><b>Date: </b></span><span style="font-family:'Helvetica';">29 October 2013 at 3:45:53 PM SAST<br></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;"><span style="font-family:'Helvetica'; color:;"><b>To: </b></span><span style="font-family:'Helvetica';"><a href="mailto:lttng-dev@lists.lttng.org" target="_blank">lttng-dev@lists.lttng.org</a><br></span></div><br><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi, could I ask that somebody please make a VERY EASY fix to LTTng and push it for me.<div><br></div><div>I get compiler warnings about a missing initialiser for member ‘padding’ in tracepoint.</div><div>Removing these warnings is really simple:</div><div><br></div><div>line 252 of “tracepoint.h” needs to change from:</div><div>
<pre style="margin-top: 0px; margin-bottom: 0px;"><span style=" color:#c0c0c0;"> </span>_TP_EXTRACT_STRING(_args),<span style=" color:#c0c0c0;"> </span><span style=" color:#c0c0c0;">\</span></pre></div><div>to:</div><div>
<pre style="margin-top: 0px; margin-bottom: 0px;"><span style=" color:#c0c0c0;"> </span>_TP_EXTRACT_STRING(_args), {}<span style=" color:#c0c0c0;"> </span><span style=" color:#c0c0c0;">\</span></pre><pre style="margin-top: 0px; margin-bottom: 0px;"><span style=" color:#c0c0c0;"><br></span></pre><pre style="margin-top: 0px; margin-bottom: 0px;"><div style="font-family: Helvetica; white-space: normal;">Thanks in advance!</div></pre></div></div></div></blockquote></div><br><div><br></div>_______________________________________________<br>lttng-dev mailing list<br>lttng-dev@lists.lttng.org<br>http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev<br></blockquote><div><br><div><br></div></div><div><br></div><div>-- <br></div><div><span name="x"></span>Mathieu Desnoyers<br>EfficiOS Inc.<br>http://www.efficios.com<span name="x"></span><br></div></div></body></html>