[lttng-dev] Bugfix: Bug #453

[Christian Babeux]

Hello Simar,

Here a few additional guidelines/tips for submitting patches:

- I see in your patches that you based yourself on my personal github
lttng-tools repository to prepare your patches. This repository might
be lagging behind the official one, hence I would suggest using the
official git repository to prepare your patch. You can find them in
"Git Repositories" in the Download [1] section on the lttng website.

- Add the following at the end of your commit message:

Fixes #453

This will automatically close the bug #453 in the bug tracker when
your patch is merged :).

- Indicate in the patch subject on which project the patch is to be
applied. In your particular case, the patches need to be applied on
the lttng-tools tree. You can accomplish this with the
'--subject-prefix' option when using the git format-patch command:

git format-patch -s -1 --subject-prefix="PATCH lttng-tools"

- Add your signoff in the patch. Use the '-s' option when using git
format-patch.

- Send the patch to the maintainer of the project and CC the list. In
your case, David Goulet (dgoulet at efficios dot com) is the
maintainer of lttng-tools. You can accomplish this with the following
git send-email command:

git send-email --to maintainer_email --cc list_email *.patch

If you want to discuss a project proposal, you can join us on IRC on
the OFTC network in the #lttng channel.

Thanks,

Christian

[1] - http://lttng.org/download

On Tue, Apr 9, 2013 at 10:43 AM, Raphaël Beamonte
<raphael.beamonte at polymtl.ca> wrote:
> Hello Simar,
>
> On 2013-04-08 23:41, Simarpreet Singh wrote:
>> 1) How do you I submit my changes to the lttng-tools repo? Do I need any
>> kind of authorization before I can do so?
>
> To submit your commit patches, you can use the "git send-email"
> functionality to send them directly to this list. After that, the
> concerned lttng devs will be able to give you their feedback and/after
> apply your patches on the main git repos.
>
>>
>> 2) What timezone do you guys work in? I had a few questions to discuss
>> regarding GSOC 2013 in details and I guess it's better to talk over IRC.
>
> Most of us are on America Eastern Time Zone.
>
> Raphaël
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>