[lttng-dev] [PATCH lttng-tools] Fix: test code assumes that child process is schedule to run before parent
Jonathan Rajotte-Julien
jonathan.rajotte-julien at efficios.com
Wed Mar 31 15:25:09 EDT 2021
> #
> # SPDX-License-Identifier: GPL-2.0-only
>
> -TEST_DESC="LTTng - Event traker test"
> +TEST_DESC="LTTng - Event tracker test"
>
> CURDIR=$(dirname "$0")/
> TESTDIR="$CURDIR/../../.."
> @@ -42,6 +42,8 @@ function prepare_ust_app
>
> $TESTAPP_BIN -i $NR_ITER -w $NR_USEC_WAIT -a "$AFTER_FIRST_PATH" -b
> "$BEFORE_LAST_PATH" &
> CHILD_PID=$!
> + # voluntary context switch to start $TESTAPP_BIN
> + sleep 0.1
A wait on the $AFTER_FIRST_PATH file would be probably more deterministic than a sleep here.
while [ ! -f "${AFTER_FIRST_PATH}" ]; do
sleep 0.1
done
I would also expect something similar for the `prepare_kernel_app` function considering the same race is most probably present and simply not triggered by a chance of luck.
Seems like gen-kernel-test-events does not expose the same sync capabilities here, please use gen-ust-events as an example of how it is done.
Let us know how your testing goes.
Thanks
More information about the lttng-dev
mailing list