[lttng-dev] [Patch LTTng-ust 6/7] Add the macros to generate the data structures for CTF named enumerations

[Stefan Seefeld]

On 01/30/2014 08:37 PM, Mathieu Desnoyers wrote:
> ----- Original Message -----
>> From: "Geneviève Bastien" <gbastien+lttng at versatic.net>
>> To: lttng-dev at lists.lttng.org
>> Sent: Friday, January 24, 2014 3:04:44 PM
>> Subject: [lttng-dev] [Patch LTTng-ust 6/7] Add the macros to generate the	data structures for CTF named enumerations
>>
>> Fills the macros to initialize the metadata for a tracepoint.
>>
>> From this patch on, the named metadata are enabled.
> Now that I think about it, "named metadata" does not seem to be semantically clear.
> Perhaps we could change this to "global type declarations" ? Because this is really
> what it is: type declarations that are in the global scope of the metadata. This applies
> to all other patches in this series.

Mathieu,

I may be misunderstanding what you intend to relabel as "global type
declarations", but I believe the term is too restrictive.
I'm following this discussion with interest, as I have another use-case
for meta-data which might be implementable very much like the named
enums: constant or "event-static" fields. For example, we may want to
store numeric values in events that need a (constant) scale factor (a
unit of measurement), which would be well represented in meta-data, as
opposed to redundantly inside events.
And so, while I agree to your characterization of named enumerations as
type declarations, I'm still looking at the mechanism as enabling the
storage of named meta-data.


Thanks,
        Stefan

-- 
Stefan Seefeld
CodeSourcery / Mentor Graphics
http://www.mentor.com/embedded-software/