[lttng-dev] [lttng-tools PATCH 0/5] Follow up to the realpath(3) for unexistent paths

Raphaël Beamonte raphael.beamonte at gmail.com
Thu Nov 14 19:58:30 EST 2013


David,

Following the discussions we had on IRC with Mathieu and the last
mail exchange, here is a series of patch that should answer to our
enquiries.

The first two patches are linked to the utils_expand_path unit test
and correct its behavior and the expected results (some input was
at first considered invalid, but during our discussions it was
mentionned that it should be considered valid).

The next three ones introduce a new utils_partial_realpath that,
as its name says it, allows to partially resolve a real path for
a given path. This function is then used in utils_expand_path to
resolve the paths, and the utils_resolve_relative function is
removed as it is not necessary anymore in this new "setup".

Waiting for your comments,
Raphaël

Raphaël Beamonte (5):
  Tests: add a check in test_utils_expand_path to avoid segfault if
    result is NULL
  Tests: move invalid tests in test_utils_expand_path that should be
    valid
  Introduce a new utils_partial_realpath function
  Change the utils_expand_path function to use utils_partial_realpath
  Remove the utils_resolve_relative function that is not useful anymore

 .gitignore                               |    1 -
 src/common/utils.c                       |  256 ++++++++++++++++++------------
 src/common/utils.h                       |    3 +-
 tests/unit/Makefile.am                   |    7 +-
 tests/unit/test_utils_expand_path.c      |    7 +-
 tests/unit/test_utils_resolve_relative.c |   98 ------------
 tests/unit_tests                         |    1 -
 7 files changed, 158 insertions(+), 215 deletions(-)
 delete mode 100644 tests/unit/test_utils_resolve_relative.c

-- 
1.7.10.4




More information about the lttng-dev mailing list