[lttng-dev] [PATCH lttng-tools] Fix: Don't dispatch uninitialized hash tables to the ht_cleanup thread

Jérémie Galarneau jeremie.galarneau at efficios.com
Mon Nov 11 14:43:16 EST 2013


Some error-handling code paths may call ht_cleanup_push() with NULL hash
tables which will crash the clean-up thread.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau at efficios.com>
---
 src/bin/lttng-sessiond/utils.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/bin/lttng-sessiond/utils.c b/src/bin/lttng-sessiond/utils.c
index 85a1f02..5efa1d4 100644
--- a/src/bin/lttng-sessiond/utils.c
+++ b/src/bin/lttng-sessiond/utils.c
@@ -54,6 +54,9 @@ void ht_cleanup_push(struct lttng_ht *ht)
 	int ret;
 	int fd = ht_cleanup_pipe[1];
 
+	if (!ht) {
+		return;
+	}
 	if (fd < 0)
 		return;
 	do {
-- 
1.8.4.2




More information about the lttng-dev mailing list