[lttng-dev] On git and mail requests

Yannick Brosseau yannick.brosseau at gmail.com
Thu Mar 28 12:06:25 EDT 2013


On 2013-03-28 12:03, Simon Marchi wrote:
> I think the point is that having patches in emails is not very
> convenient. Given the quality of web based tools available today, I
> think it would be relevant that the LTTng project adopt one of them.
>
> With the current system:
> - it is hard to see what the resulting code is. You juste have a blob
> of + and -, and it is very hard to see what the code looks in the
> end. Web based code review tools allow you to quickly see the
> modifications as part of the complete file, with nice colors and other
> visual aids.
> - It is hard to follow the sequence of comments. With a web based
> tool, all discussions related to a topic are clearly laid out.
> - It is hard to follow the evolution of a patch (differences between
> patch versions)
> - Sometimes patches on the list fall into cracks and are never replied to.
>
>
Is there any of the available code review tools that can work offline?



More information about the lttng-dev mailing list