[lttng-dev] On git and mail requests

Simon Marchi simon.marchi at polymtl.ca
Thu Mar 28 12:03:01 EDT 2013


I think the point is that having patches in emails is not very
convenient. Given the quality of web based tools available today, I
think it would be relevant that the LTTng project adopt one of them.

With the current system:
- it is hard to see what the resulting code is. You juste have a blob
of + and -, and it is very hard to see what the code looks in the
end. Web based code review tools allow you to quickly see the
modifications as part of the complete file, with nice colors and other
visual aids.
- It is hard to follow the sequence of comments. With a web based
tool, all discussions related to a topic are clearly laid out.
- It is hard to follow the evolution of a patch (differences between
patch versions)
- Sometimes patches on the list fall into cracks and are never replied to.

Code review has proven to be very useful to maintain code quality and
avoid bugs. It might be only me, but the current system doesn't
encourage me to go look at other people's code and comment, because it
is hard to do so.

Simon

On 28 March 2013 11:12, Jérémie Galarneau
<jeremie.galarneau at efficios.com> wrote:
> I know some projects use separate dev and user mailing lists. Perhaps
> we could follow this route.
>
> Jérémie
>
> On Thu, Mar 28, 2013 at 11:03 AM, Matthew Khouzam
> <matthew.khouzam at ericsson.com> wrote:
>> Hello tracing sorcerers,
>>
>> I was having a harder and harder time reading the mailing list's
>> discussions. I have a filter to hide "patches" in my mail client. I
>> think though it would be interesting maybe to use redmine's code review
>> system and keep the mailing list for support? That way we can see the
>> user issues more easily?
>>
>> Any thoughts?
>> Matthew
>>
>>
>>
>> _______________________________________________
>> lttng-dev mailing list
>> lttng-dev at lists.lttng.org
>> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
>
>
> --
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev



More information about the lttng-dev mailing list