[lttng-dev] [LTTng-modules PATCH] The msg part of the printk:console event was 1 character too long

[Yannick Brosseau]

On 2013-06-28 15:43, Mathieu Desnoyers wrote:
> * Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
>> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>> ---
>>  instrumentation/events/lttng-module/printk.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/instrumentation/events/lttng-module/printk.h b/instrumentation/events/lttng-module/printk.h
>> index 4c744f9..f4b6028 100644
>> --- a/instrumentation/events/lttng-module/printk.h
>> +++ b/instrumentation/events/lttng-module/printk.h
>> @@ -19,7 +19,7 @@ TRACE_EVENT_CONDITION(console,
>>  
>>  	TP_STRUCT__entry(
>>  		__dynamic_array_text(char, msg,
>> -			min_t(unsigned, end - start, MSG_TRACE_MAX_LEN) + 1)
> this was taken from the Linux kernel mainline instrumentation, no ?
>
> Has this been fixed upstream ? If so, can you cite the commit in the
> changelog ?
>
>
It's not changed upstream. From what I see, ftrace does the right thing,
but not LTTng. Will check perf and see if I can reproduce the problem
directly with the upstream kernel.