[lttng-dev] [PATCH 1/3] Improve delete of configuration

[Francis Giraldeau]

Le 2012-05-29 20:43, David Goulet a écrit :
> > + if (!config_exists(config_path)) + goto done;
>
> Please add {} even for a one liner if().

I used checkpatch.pl from kernel scripts and the standard there is to
remove them. I can add them, but then patches will not pass the check.
IMHO I would follow the kernel style, since this makes easier for
everyone to check their patches. Or maybe there are options to skip
on-line-if-brace check? There is "--ignore BRACES" but then errors are
reported, only the description is not shown. Will wait for your input on
this.

>
> > + + DBG("Removing %s\n", config_path); ret = remove(config_path); if
(ret <
> > 0) { perror("remove config file"); } - +done:
>
> Accross the code, we uses "end:" instead of "done:".

ok

>
> > free(config_path); }
>
> > /* + * config_destroy_default + * + * Destroys the default config + */ +
>
> No space here and no double space before "*__Destr..." . Most of the
comments
> are still like that in that file but we are trying to move away from that
> comments format.

ok, better to put only a space, I put two because there were two at many
places. Will then provide a patch to fix other comments in the same file.

Francis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120530/d5c9bc06/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4476 bytes
Desc: Signature cryptographique S/MIME
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120530/d5c9bc06/attachment.bin>