<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Le 2012-05-29 20:43, David Goulet a écrit :<br>
<span style="white-space: pre;">> > + if
(!config_exists(config_path)) + goto done;<br>
><br>
> Please add {} even for a one liner if().</span><br>
<br>
I used checkpatch.pl from kernel scripts and the standard there is
to remove them. I can add them, but then patches will not pass the
check. IMHO I would follow the kernel style, since this makes easier
for everyone to check their patches. Or maybe there are options to
skip on-line-if-brace check? There is "--ignore BRACES" but then
errors are reported, only the description is not shown. Will wait
for your input on this.<br>
<br>
<span style="white-space: pre;">><br>
> > + + DBG("Removing %s\n", config_path); ret =
remove(config_path); if (ret <<br>
> > 0) { perror("remove config file"); } - +done:<br>
><br>
> Accross the code, we uses "end:" instead of "done:".</span><br>
<br>
ok<br>
<br>
<span style="white-space: pre;">><br>
> > free(config_path); }<br>
><br>
> > /* + * config_destroy_default + * + * Destroys the
default config + */ +<br>
><br>
> No space here and no double space before "*__Destr..." . Most
of the comments<br>
> are still like that in that file but we are trying to move
away from that<br>
> comments format.</span><br>
<br>
ok, better to put only a space, I put two because there were two at
many places. Will then provide a patch to fix other comments in the
same file.<br>
<br>
Francis<br>
<br>
</body>
</html>