[ltt-dev] [QUICKSTART] LTTng submitter quickstart guide

[Mathieu Desnoyers]

* Mathieu Desnoyers (compudj at krystal.dyndns.org) wrote:
[...]
> Thanks for submitting this. A few points for next time: please generate
> a diff of the changes, and submit it directly in the email body (without
> formatting). This helps accelerate the review process. Meanwhile, I
> generated the diff from your code for review below,

By the way, I heavily recommend using "quilt" to manage your stack of
patches. quickstart:

get a clean babeltrace tree (without your modifications)
cd babeltrace
quilt new descritive-patch-name.patch
quilt add converter/babeltrace.c
quilt add converter/babeltrace-lib.c
<make your changes>
quilt refresh --diffstat
quilt header -e
<type in your patch description:>
One liner subject

Longer multi-line description

Signed-off-by: Name <email>
<with the rest of the diffstat-generated summary that follows>

You can then embed the patches/descritive-patch-name.patch in a email,
putting as subject:
[Babeltrace PATCH] One liner subject

Make sure your email client does not wrap long lines (see Linux kernel
Documentation/email-clients.txt for more info). You can also experience
with "quilt mail" if you want to send your patch stack by email, but it
requires your smtp setup to be setup correctly on your machine.

When you want to move around in your patch stack, use "quilt pop" and
"quilt push". quilt pop -a to unapply all, quilt push -a to apply all
the patches/series file. See "man quilt" for more info.

You can edit the patches/series file to remove patches you don't want
anymore (make sure they are not applied when you remove them). 

To check the coding style automatically before sending, I use something
like this:

quilt pop -a
for a in $(cat patches/series); do quilt push; \
	PATH_TO_LINUX_TREE/scripts/checkpatch.pl $(quilt top); \
done

Please forward this to the rest of your team. I hope this helps,

Best Regards,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com