[ltt-dev] BabelTrace - a Few Issues

[Mathieu Desnoyers]

* Amer Alhalabi (amer.alhalabi at ericsson.com) wrote:
> 
> Hi Guys,
> 
> I've started looking at Babeltrace code recently and I have two questions if you don't mind.
> 
> 1. In babeltrace.c  the main function , there are two if-conditions checking the same thing (but handled differently!). I think the second condition is not needed, correct?
> 
> if (!opt_input_format)
>         opt_input_format = "ctf";
> 
> ///Here
> if (!opt_output_format)
>         opt_output_format = "text";
> 
> 
> fmt_read = bt_lookup_format(g_quark_from_static_string(opt_input_format));
> if (!fmt_read) {
> fprintf(stdout, "[error] Format \"%s\" is not supported.\n\n",opt_input_format);
> exit(EXIT_FAILURE);
> }
> 
> ///Here
> if (!opt_output_format)
>         opt_output_format = "ctf";

Right. Fixed in git. commit 7888b6fc7863595be5f41ec9d73550791750b1f9

> 
> 
> 2. trace_descriptor structure is empty. What's the use of that?

For the inheritance performed with "container_of" macro. See in which
structure it is embedded.

Thanks,

Mathieu

> 
> 
> Thanks,
> Amer
> 
> 
> 
> 
> AMER ALHALABI
> Software Developer
> 
> Ericsson Canada Inc.
> Common Components
> 8500 Decarie Blvd
> H4P 2N2, Mount Royal, QC, Canada
> Phone +1 514 345-7900 ext. 43082
> amer.alhalabi at ericsson.com
> www.ericsson.com
> 
> 
>  <http://www.ericsson.com/>
> 
> This Communication is Confidential. We only send and receive email on the basis of the terms set out at www.ericsson.com/email_disclaimer<http://www.ericsson.com/email_disclaimer>
> 
> 



> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev


-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com