[ltt-dev] BabelTrace - a Few Issues

[Amer Alhalabi]

Hi Guys,

I've started looking at Babeltrace code recently and I have two questions if you don't mind.

1. In babeltrace.c  the main function , there are two if-conditions checking the same thing (but handled differently!). I think the second condition is not needed, correct?

if (!opt_input_format)
        opt_input_format = "ctf";

///Here
if (!opt_output_format)
        opt_output_format = "text";


fmt_read = bt_lookup_format(g_quark_from_static_string(opt_input_format));
if (!fmt_read) {
fprintf(stdout, "[error] Format \"%s\" is not supported.\n\n",opt_input_format);
exit(EXIT_FAILURE);
}

///Here
if (!opt_output_format)
        opt_output_format = "ctf";


2. trace_descriptor structure is empty. What's the use of that?


Thanks,
Amer




AMER ALHALABI
Software Developer

Ericsson Canada Inc.
Common Components
8500 Decarie Blvd
H4P 2N2, Mount Royal, QC, Canada
Phone +1 514 345-7900 ext. 43082
amer.alhalabi at ericsson.com
www.ericsson.com


 <http://www.ericsson.com/>

This Communication is Confidential. We only send and receive email on the basis of the terms set out at www.ericsson.com/email_disclaimer<http://www.ericsson.com/email_disclaimer>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20110712/a6eb9c12/attachment-0002.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Picture (Device Independent Bitmap) 1.jpg
Type: image/jpeg
Size: 798 bytes
Desc: Picture (Device Independent Bitmap) 1.jpg
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20110712/a6eb9c12/attachment-0006.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Picture (Device Independent Bitmap) 2.jpg
Type: image/jpeg
Size: 2695 bytes
Desc: Picture (Device Independent Bitmap) 2.jpg
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20110712/a6eb9c12/attachment-0007.jpg>