[lttng-dev] [LTTV PATCH 2/2] Fix some implicit-function-declaration warnings

Mathieu Desnoyers compudj at krystal.dyndns.org
Wed Dec 7 10:37:56 EST 2011


* Alexandre Montplaisir (alexandre.montplaisir at gmail.com) wrote:
> time_span -> timespan inconsistency
> Add a missing prototype to lttvwindow/callbacks.c
> 
> Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir at gmail.com>

merged, thanks!

Mathieu

> ---
>  lttv/modules/gui/detailedevents/events.c           |    4 ++--
>  lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c |    4 +++-
>  .../modules/gui/lttvwindow/lttvwindow/lttvwindow.c |    4 ++--
>  3 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/lttv/modules/gui/detailedevents/events.c b/lttv/modules/gui/detailedevents/events.c
> index ae749ea..70696dc 100644
> --- a/lttv/modules/gui/detailedevents/events.c
> +++ b/lttv/modules/gui/detailedevents/events.c
> @@ -212,7 +212,7 @@ gui_events(LttvPluginTab *ptab)
>                  update_current_position,event_viewer_data);
>    lttvwindow_register_traceset_notify(tab, 
>                  traceset_changed,event_viewer_data);
> -  lttvwindow_register_time_span_notify(tab, 
> +  lttvwindow_register_timespan_notify(tab, 
>                  timespan_changed,event_viewer_data);
>    lttvwindow_register_filter_notify(tab,
>                  filter_changed, event_viewer_data);
> @@ -1888,7 +1888,7 @@ void gui_events_free(gpointer data)
>      //                    show_event_detail, event_viewer_data);
>      lttvwindow_unregister_traceset_notify(tab,
>                          traceset_changed, event_viewer_data);
> -    lttvwindow_unregister_time_span_notify(tab,
> +    lttvwindow_unregister_timespan_notify(tab,
>  				    timespan_changed,event_viewer_data);
>      lttvwindow_unregister_filter_notify(tab,
>                          filter_changed, event_viewer_data);
> diff --git a/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c b/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c
> index 310607d..7243082 100644
> --- a/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c
> +++ b/lttv/modules/gui/lttvwindow/lttvwindow/callbacks.c
> @@ -75,6 +75,8 @@ char * get_selection(MainWindow *mw,
>  void init_tab(Tab *tab, MainWindow * mw, Tab *copy_tab,
>  		  GtkNotebook * notebook, char * label);
>  
> +int update_traceset(Tab *tab, LttvTraceset *traceset);
> +
>  static void insert_viewer(GtkWidget* widget, lttvwindow_viewer_constructor constructor);
>  
>  LttvPluginTab *create_new_tab(GtkWidget* widget, gpointer user_data);
> @@ -303,7 +305,7 @@ int SetTraceset(Tab * tab, LttvTraceset *traceset)
>    }
>  
>    /* Finally, call the update hooks of the viewers */
> -  gint retval = update_traceset(tab,traceset);
> +  gint retval = update_traceset(tab, traceset);
>  
>    time_change_manager(tab, new_time_window);
>    current_time_change_manager(tab, new_current_time);
> diff --git a/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindow.c b/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindow.c
> index acb968b..56a847e 100644
> --- a/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindow.c
> +++ b/lttv/modules/gui/lttvwindow/lttvwindow/lttvwindow.c
> @@ -474,7 +474,7 @@ __EXPORT void lttvwindow_unregister_time_window_notify(Tab *tab,
>   * @param hook hook function of the viewer.
>   * @param hook_data hook data associated with the hook function.
>   */
> -__EXPORT void lttvwindow_register_time_span_notify(Tab *tab,
> +__EXPORT void lttvwindow_register_timespan_notify(Tab *tab,
>      LttvHook hook, gpointer hook_data)
>  {
>    LttvAttributeValue value;
> @@ -499,7 +499,7 @@ __EXPORT void lttvwindow_register_time_span_notify(Tab *tab,
>   * @param hook_data hook data associated with the hook function.
>   */
>  
> -__EXPORT void lttvwindow_unregister_time_span_notify(Tab *tab,
> +__EXPORT void lttvwindow_unregister_timespan_notify(Tab *tab,
>      LttvHook hook, gpointer hook_data)
>  {
>    LttvAttributeValue value;
> -- 
> 1.7.7.3
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com



More information about the lttng-dev mailing list