[lttng-dev] [lttng-tools PATCH v3 2/3] Clarify 32/64_path options in configure.ac

[Alexandre Montplaisir]

On 11-12-05 03:45 PM, Mathieu Desnoyers wrote:
> * Alexandre Montplaisir (alexandre.montplaisir at gmail.com) wrote:
>> As per the previous commit, only ask the user to specify the path
>> (basename) when using the consumerd32/64_path configure options.
>> The build system itself will append the filename. This way only
>> directory names are used as options, which can hopefully reduce
>> confusion.
>>
>> Also clarified the options help text.
>>
>> Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir at gmail.com>
>> ---
>>  configure.ac |   12 ++++++------
>>  1 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 3c09729..b50f056 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -16,28 +16,28 @@ AC_CHECK_HEADERS([ \
>>  
>>  AC_ARG_WITH([consumerd32-path],
>>  	AS_HELP_STRING([--with-consumerd32-path],
>> -	[Location of the 32-bit consumerd executable]),
>> -	[CONSUMERD32_PATH="$withval"],
>> +	[Directory containing the 32-bit 'lttng-consumerd' executable]),
>> +	[CONSUMERD32_PATH="${withval}/lttng-consumerd"],
> any thought on PATH to BINDIR renaming ?
>

As I mentioned in the previous thread, I don't think BINDIR is a good
choice here, since it could be confused with configure's --bindir option
(we are not installing in this directory, this is merely a lookup
configuration).

But I agree we should have a different name for the user-facing option
and the substitution variable, since we change its meaning. Perhaps
-execdir for the option and keep _PATH for the variable? or _FILENAME ?

-- 
Alexandre Montplaisir
DORSAL lab,
École Polytechnique de Montréal