[lttng-dev] [lttng-tools PATCH v3 2/3] Clarify 32/64_path options in configure.ac

[Mathieu Desnoyers]

* Alexandre Montplaisir (alexandre.montplaisir at gmail.com) wrote:
> As per the previous commit, only ask the user to specify the path
> (basename) when using the consumerd32/64_path configure options.
> The build system itself will append the filename. This way only
> directory names are used as options, which can hopefully reduce
> confusion.
> 
> Also clarified the options help text.
> 
> Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir at gmail.com>
> ---
>  configure.ac |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 3c09729..b50f056 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -16,28 +16,28 @@ AC_CHECK_HEADERS([ \
>  
>  AC_ARG_WITH([consumerd32-path],
>  	AS_HELP_STRING([--with-consumerd32-path],
> -	[Location of the 32-bit consumerd executable]),
> -	[CONSUMERD32_PATH="$withval"],
> +	[Directory containing the 32-bit 'lttng-consumerd' executable]),
> +	[CONSUMERD32_PATH="${withval}/lttng-consumerd"],

any thought on PATH to BINDIR renaming ?

>  	[CONSUMERD32_PATH=''])
>  AC_SUBST([CONSUMERD32_PATH])
>  
>  AC_ARG_WITH([consumerd64-path],
>  	AS_HELP_STRING([--with-consumerd64-path],
> -	[Location of the 64-bit consumerd executable]),
> -	[CONSUMERD64_PATH="$withval"],
> +	[Directory containing the 64-bit 'lttng-consumerd' executable]),
> +	[CONSUMERD64_PATH="${withval}/lttng-consumerd"],
>  	[CONSUMERD64_PATH=''])
>  AC_SUBST([CONSUMERD64_PATH])
>  
>  AC_ARG_WITH([consumerd32-libdir],
>  	AS_HELP_STRING([--with-consumerd32-libdir],
> -	[Location of the 32-bit consumerd libraries]),
> +	[Location of the 32-bit consumer libraries]),
>  	[CONSUMERD32_LIBDIR="$withval"],
>  	[CONSUMERD32_LIBDIR=''])
>  AC_SUBST([CONSUMERD32_LIBDIR])
>  
>  AC_ARG_WITH([consumer64d-libdir],
>  	AS_HELP_STRING([--with-consumerd64-libdir],
> -	[Location of the 64-bit consumerd libraries]),
> +	[Location of the 64-bit consumer libraries]),
>  	[CONSUMERD64_LIBDIR="$withval"],
>  	[CONSUMERD64_LIBDIR=''])
>  AC_SUBST([CONSUMERD64_LIBDIR])
> -- 
> 1.7.7.3
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com