[lttng-dev] [lttng-tools PATCH v2 2/4] Clarify 32/64_path options in configure.ac

[Alexandre Montplaisir]

On 11-12-05 01:34 PM, Mathieu Desnoyers wrote:
> * Alexandre Montplaisir (alexandre.montplaisir at gmail.com) wrote:
>> As per the previous commit, only ask the user to specify the path
>> (basename) when using the consumerd32/64_path configure options.
>> The build system itself will append the filename. This way only
>> directory names are used as options, which can hopefully reduce
>> confusion.
>>
>> Also clarified the options help text.
>>
>> Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir at gmail.com>
>> ---
>>  configure.ac |   12 ++++++------
>>  1 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 3c09729..b50f056 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -16,28 +16,28 @@ AC_CHECK_HEADERS([ \
>>  
>>  AC_ARG_WITH([consumerd32-path],
>>  	AS_HELP_STRING([--with-consumerd32-path],
>> -	[Location of the 32-bit consumerd executable]),
>> -	[CONSUMERD32_PATH="$withval"],
>> +	[Directory containing the 32-bit 'lttng-consumerd' executable]),
> Then "path" should become "bindir" ?
>
> Thanks,
>
> Mathieu
>

Yes, it would be nice to have a distinction between the "path the user
passes" and the "dirname+filename we use in the program".
However I didn't pick "consumerd32_bindir" because I thought it would be
confusing with the --bindir argument:  we are not actually installing
the consumer in this directory, it's only the place where the sessiond
will look for once it's installed.

Right now I am not exactly sure what is the best way to handle this. A
suggestion was to always install the lttng-consumerd in the libdir, and
configure the lttng-sessiond appropriately. This would reduce the number
of "paths" to configure from 4 to 2.

Thanks for the feedback!

-- 
Alexandre Montplaisir
DORSAL lab,
École Polytechnique de Montréal