[ltt-dev] new ltt-trace-control module based on debugfs(v2)

[Mathieu Desnoyers]

* Zhaolei (zhaolei at cn.fujitsu.com) wrote:
> * Mathieu Desnoyers wrote:
> >> By this way, dir hiberarchy is not changed.(so we need not modify user-mode tools now)
> >> But ltt-trace-control.ko can get dentry of debugfs/ltt by calling get_ltt_debug_root().
> >> 
> >> In future, both ltt-relay and ltt-relay-locked will do following in init()
> >> ltt_relay_dentry = debugfs_create_dir(LTT_RELAY_ROOT, get_ltt_debug_root());
> >> (OR ltt_relay_dentry = debugfs_create_dir(LTT_RELAY_LOCKED_ROOT, get_ltt_debug_root());)
> >> 
> >> What is your opinion?
> >> 
> > 
> > Yes, that's fine with me. I just wonder why we would not create the
> > debugfs ltt/ directory directly in ltt-core.c init() ?
> 
> Hello, Mathieu
> 
> Thanks for your answer.
> 
> Because following reason:
> 1: no init() in ltt-core.c(sure we can add it)

yes

> 2: if ltt-relay and ltt-relay-locked compiled into kernel, ltt-relay's init()
>    maybe called prior to ltt-core's init. In ltt-relay's init, it needs use
>    ltt-root-dentry, but ltt-root-dentry is not inited this time.

Hrm, yes, I see. So the get() approach looks fine.

Thanks,

Mathieu

> 
> B.R.
> Zhaolei
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68