<div dir="ltr">Thanks Michael, the patch is working<div><br></div><div>[  157.606699]  SK DEBUG look up symbol .kallsyms_lookup_name<br>[  157.613527]  SK DEBUG look up symbol get_pfnblock_flags_mask<br>[  157.644191] LTTng: Loaded modules v2.13.8 (Nordicité) - devtool-base-1-g1011df74-dirty<br></div><div><br></div><div>Regards,</div><div>Shahank </div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 27, 2023 at 11:59 PM Michael Jeanson <<a href="mailto:mjeanson@efficios.com">mjeanson@efficios.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2023-03-27 11:52, yashvardhan kukreti wrote:<br>
>   62 #ifdef LTTNG_CONFIG_PPC64_ELF_ABI_V2<br>
>   63         /* Substract 4 bytes to get what we originally want */<br>
>   64         addr = (unsigned long)(((char *)probe.addr) - 4);<br>
>   65 #elif defined*(LTTNG_*CONFIG_PPC64_ELF_ABI_V1)   << incorrect MACRO to <br>
> used in gerrit review. this is the correct one.<br>
>   66         /*<br>
>   67          * Build a function descriptor from the address of<br>
> <br>
> /lttng-module-2.13.8/src/wrapper/kallsyms.c:72:32: error: invalid use of <br>
> undefined type 'struct func_desc'<br>
> |    72 |  kallsyms_lookup_name_func_desc.addr = (unsigned long)probe.addr;<br>
> /lttng-module-2.13.8/src/wrapper/kallsyms.c:73:32: error: invalid use of <br>
> undefined type 'struct func_desc'<br>
> |    73 |  kallsyms_lookup_name_func_desc.toc = ((struct func_desc *) <br>
> &sprint_symbol)->toc;<br>
> <br>
> you either want to use func_descr_t<br>
> <a href="https://elixir.bootlin.com/linux/v5.15.104/source/arch/powerpc/include/asm/types.h#L30" rel="noreferrer" target="_blank">https://elixir.bootlin.com/linux/v5.15.104/source/arch/powerpc/include/asm/types.h#L30</a> <<a href="https://elixir.bootlin.com/linux/v5.15.104/source/arch/powerpc/include/asm/types.h#L30" rel="noreferrer" target="_blank">https://elixir.bootlin.com/linux/v5.15.104/source/arch/powerpc/include/asm/types.h#L30</a>><br>
> or<br>
> struct ppc64_opd_entry<br>
> <a href="https://elixir.bootlin.com/linux/v5.17.15/source/arch/powerpc/include/uapi/asm/elf.h#L293" rel="noreferrer" target="_blank">https://elixir.bootlin.com/linux/v5.17.15/source/arch/powerpc/include/uapi/asm/elf.h#L293</a> <<a href="https://elixir.bootlin.com/linux/v5.17.15/source/arch/powerpc/include/uapi/asm/elf.h#L293" rel="noreferrer" target="_blank">https://elixir.bootlin.com/linux/v5.17.15/source/arch/powerpc/include/uapi/asm/elf.h#L293</a>><br>
> <br>
> both of which are discontinued from 5.18<br>
<br>
<br>
Hi,<br>
<br>
I updated the patch at <a href="https://review.lttng.org/c/lttng-modules/+/9113" rel="noreferrer" target="_blank">https://review.lttng.org/c/lttng-modules/+/9113</a> to <br>
support kernels older than v5.18. It's only build tested on v5.17 and v5.18.<br>
<br>
Michael<br>
<br>
</blockquote></div>