<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI Symbol";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.emailstyle17
{mso-style-name:emailstyle17;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.htmlpreformattedchar0
{mso-style-name:htmlpreformattedchar;
font-family:"Courier New";}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-IN" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US">Thanks for the information.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US">I have pulled in all commits up till v4.14.200, not some random commit, I have mentioned the commit ID in the mail for reference because of which I was facing the error.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US">Is there something you can help me with?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Mathieu Desnoyers [mailto:mathieu.desnoyers@efficios.com]
<br>
<b>Sent:</b> 20 October 2020 20:04<br>
<b>To:</b> Naaz, Syeda Shagufta <SyedaShagufta_Naaz@mentor.com><br>
<b>Cc:</b> lttng-dev <lttng-dev@lists.lttng.org><br>
<b>Subject:</b> Re: [lttng-dev] Error in lttng-modules after pulling in commit 'writeback: Fix sync livelock due to b_dirty_time processing'<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">----- On Oct 20, 2020, at 2:59 AM, lttng-dev <<a href="mailto:lttng-dev@lists.lttng.org">lttng-dev@lists.lttng.org</a>> wrote:<br>
<br>
<o:p></o:p></span></p>
</div>
<div>
<blockquote style="border:none;border-left:solid #1010FF 1.5pt;padding:0cm 0cm 0cm 4.0pt;margin-left:3.75pt;margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:black">Hi All,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">I’m facing compilation error in build after pulling in the stable kernel LTS(4.14.y) commit -
<a href="https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.14.y&id=77322edb99f0176ec67a300b9f263719ba391b89" target="_blank">
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.14.y&id=77322edb99f0176ec67a300b9f263719ba391b89</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
</blockquote>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">Hi,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">lttng-modules tracks the stable kernels through their versions (e.g. 4.14.165). There are ifdefs in the<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">lttng-modules code to choose the right instrumentation implementation based on the kernel version it is<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">built against.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">Of course, if you don't follow the versioning scheme of the stable kernels and cherry-pick random commits,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">there is little lttng-modules can do to track those changes. We have worked with Ubuntu, Redhat and Debian<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">distributions to ensure their kernels are versioned in a way which is also detected by lttng-modules, in the<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">situations where the kernels diverge from upstream. If you want to create your own kernel which also<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">differs from all other existing kernels out there, you will also need to take care of versioning it and adapt<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">lttng-modules accordingly.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">Thanks,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">Mathieu<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #1010FF 1.5pt;padding:0cm 0cm 0cm 4.0pt;margin-left:3.75pt;margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:black">I tried this solution - <a href="https://github.com/lttng/lttng-modules/commit/7318a1e88c8097733f5a05529069e4e03c142cae" target="_blank">
https://github.com/lttng/lttng-modules/commit/7318a1e88c8097733f5a05529069e4e03c142cae</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">But this also didn’t resolve my problem.
<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| In file included from /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/../probes/define_trace.h</span><span style="font-size:10.0pt;font-family:"Segoe UI Symbol",sans-serif;color:#7F7F7F">💯</span><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">0,</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| from /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/../instrumentation/events/lttng-module/writeback.h:735,</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| from /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/lttng-probe-writeback.c:51:</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/../probes/lttng-tracepoint-event-impl.h:143:6:
error: conflicting types for 'trace_writeback_queue_io'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| void trace_##_name(_proto);</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/../probes/lttng-tracepoint-event-impl.h:55:2:
note: in expansion of macro 'LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(map, name, map, PARAMS(proto), PARAMS(args))</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/../probes/lttng-tracepoint-event-impl.h:97:2:
note: in expansion of macro 'LTTNG_TRACEPOINT_EVENT_MAP'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| LTTNG_TRACEPOINT_EVENT_MAP(name, name, \</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^~~~~~~~~~~~~~~~~~~~~~~~~~</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/../instrumentation/events/lttng-module/writeback.h:375:1:
note: in expansion of macro 'LTTNG_TRACEPOINT_EVENT'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| LTTNG_TRACEPOINT_EVENT(writeback_queue_io,</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^~~~~~~~~~~~~~~~~~~~~~</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| In file included from /home/snaaz/elm/8up/main/build_zcu/tmp/work-shared/zcu102-zynqmp-mel/kernel-source/include/trace/events/writeback.h:8:0,</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| from /home/snaaz/elm/8up/main/build_zcu/tmp/work/zcu102_zynqmp_mel-mel-linux/lttng-modules/2.10.9-r0/lttng-modules-2.10.9/probes/lttng-probe-writeback.c:33:</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work-shared/zcu102-zynqmp-mel/kernel-source/include/linux/tracepoint.h:187:21: note:
previous definition of 'trace_writeback_queue_io' was here</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| static inline void trace_##name(proto) \</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work-shared/zcu102-zynqmp-mel/kernel-source/include/linux/tracepoint.h:352:2: note: in
expansion of macro '__DECLARE_TRACE'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^~~~~~~~~~~~~~~</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work-shared/zcu102-zynqmp-mel/kernel-source/include/linux/tracepoint.h:488:2: note: in
expansion of macro 'DECLARE_TRACE'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| ^~~~~~~~~~~~~</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| /home/snaaz/elm/8up/main/build_zcu/tmp/work-shared/zcu102-zynqmp-mel/kernel-source/include/trace/events/writeback.h:361:1: note:
in expansion of macro 'TRACE_EVENT'</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal" style="margin-top:7.5pt;background:#F1F8FF"><span style="font-size:10.0pt;font-family:Consolas;color:#7F7F7F">| TRACE_EVENT(writeback_queue_io,</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Kindly look into it and do the needful. Thanks!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Syeda Shagufta Naaz<o:p></o:p></span></p>
<p class="MsoNormal" style="background:white"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#191919;background:white">Software Development Engineer | Mentor Embedded Linux</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:18.0pt;font-family:"Arial",sans-serif;color:#C00000;background:white">Mentor</span></b><b><span style="font-family:"Arial",sans-serif;color:#191919;background:white">,</span></b><span style="font-size:10.0pt;color:#2E74B5;background:white">A
Siemens Business</span><span style="color:black"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Helvetica",sans-serif;color:black"><br>
_______________________________________________<br>
lttng-dev mailing list<br>
<a href="mailto:lttng-dev@lists.lttng.org">lttng-dev@lists.lttng.org</a><br>
<a href="https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev">https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev</a><o:p></o:p></span></p>
</blockquote>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">--
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black">Mathieu Desnoyers<br>
EfficiOS Inc.<br>
<a href="http://www.efficios.com">http://www.efficios.com</a><o:p></o:p></span></p>
</div>
</div>
</div>
</body>
</html>