<div dir="ltr">Simon,<div><br></div><div>Yes, I will be happy to give this a try. What's the easiest way to get this patch? (Sorry, I'm less familiar with Gerrit...)</div><div><br></div><div>Rocky</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 23, 2020 at 9:44 AM Simon Marchi <<a href="mailto:simark@simark.ca">simark@simark.ca</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2020-03-20 11:12 p.m., Simon Marchi via lttng-dev wrote:<br>
> So since distutils really wants to compile the Python native modules using all the same<br>
> flags as the Python interpreter was built with, I presume that they really assume that<br>
> you'll be using the exact same toolchain to build your module as was used to build the<br>
> interpreter. Maybe we could just not pass CC/CFLAGS when building the Python module,<br>
> so it will simply be built with the same compiler/linker as Python was built with, and<br>
> we'll avoid all these problems...<br>
<br>
If we want to go this route, here's a patch that implements it.<br>
<br>
<a href="https://review.lttng.org/c/babeltrace/+/3257" rel="noreferrer" target="_blank">https://review.lttng.org/c/babeltrace/+/3257</a><br>
<br>
This makes it so we don't override the compiler or flags (other than necessary includes<br>
flags) when building the native module. So when configuring with CC=clang, the Python<br>
native module gets built with the Python distribution's default compiler, with just the<br>
flags it wants.<br>
<br>
Could you check if that works with CC=icc as well?<br>
<br>
Simon<br>
</blockquote></div>