<div dir="ltr"><div>Merged in master and stable-2.10 with a minor fix.</div><div><br></div><div>Thanks!<br></div><div>Jérémie</div><div><br></div><div><div class="gmail_extra"><br><div class="gmail_quote">On 18 May 2018 at 17:45, Jonathan Rajotte <span dir="ltr"><<a href="mailto:jonathan.rajotte-julien@efficios.com" target="_blank">jonathan.rajotte-julien@efficios.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The doc is clear about the order of precedence regarding configuration.<br>
<br>
The command line options always override any config file or<br>
configuration by environment variables.<br>
<br>
Signed-off-by: Jonathan Rajotte <<a href="mailto:jonathan.rajotte-julien@efficios.com">jonathan.rajotte-julien@<wbr>efficios.com</a>><br>
---<br>
src/bin/lttng-sessiond/main.c | 9 ++++++---<br>
1 file changed, 6 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/bin/lttng-sessiond/main.<wbr>c b/src/bin/lttng-sessiond/main.<wbr>c<br>
index 37c0a932..de8df2e0 100644<br>
--- a/src/bin/lttng-sessiond/main.<wbr>c<br>
+++ b/src/bin/lttng-sessiond/main.<wbr>c<br>
@@ -5775,6 +5775,12 @@ int main(int argc, char **argv)<br>
goto exit_set_signal_handler;<br>
}<br>
<br>
+ /* <br></blockquote><div><br></div><div>There's a trailing whitespace here ^.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ * Init config from environment variables.<br>
+ * Command line option override env configuration per-doc. Do env first.<br>
+ */<br>
+ sessiond_config_apply_env_<wbr>config(&config);<br>
+<br>
/*<br>
* Parse arguments and load the daemon configuration file.<br>
*<br>
@@ -5789,9 +5795,6 @@ int main(int argc, char **argv)<br>
goto exit_options;<br>
}<br>
<br>
- /* Init config from environment variables. */<br>
- sessiond_config_apply_env_<wbr>config(&config);<br>
-<br>
/*<br>
* Resolve all paths received as arguments, configuration option, or<br>
* through environment variable as absolute paths. This is necessary<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.0<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Jérémie Galarneau<br>EfficiOS Inc.<br><a href="http://www.efficios.com" target="_blank">http://www.efficios.com</a></div>
</div></div></div>