<div dir="ltr">The title of this patch has an extra comma.<br><div><div class="gmail_extra"><br><div class="gmail_quote">On 18 May 2018 at 17:16, Jonathan Rajotte <span dir="ltr"><<a href="mailto:jonathan.rajotte-julien@efficios.com" target="_blank">jonathan.rajotte-julien@efficios.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Jonathan Rajotte <<a href="mailto:jonathan.rajotte-julien@efficios.com">jonathan.rajotte-julien@<wbr>efficios.com</a>><br>
---<br>
src/bin/lttng-sessiond/<wbr>sessiond-config.c | 49 +++++++++++++++---------<br>
1 file changed, 31 insertions(+), 18 deletions(-)<br>
<br>
diff --git a/src/bin/lttng-sessiond/<wbr>sessiond-config.c b/src/bin/lttng-sessiond/<wbr>sessiond-config.c<br>
index 587f2f82..c0e0fec3 100644<br>
--- a/src/bin/lttng-sessiond/<wbr>sessiond-config.c<br>
+++ b/src/bin/lttng-sessiond/<wbr>sessiond-config.c<br>
@@ -501,22 +501,35 @@ void sessiond_config_log(struct sessiond_config *config)<br>
config->agent_tcp_port.begin,<br>
config->agent_tcp_port.end);<br>
}<br>
- DBG_NO_LOC("\tapplication socket timeout: %i", config->app_socket_timeout);<br>
- DBG_NO_LOC("\tno-kernel: %s", config->no_kernel ? "True" : "False");<br>
- DBG_NO_LOC("\tbackground: %s", config->background ? "True" : "False");<br>
- DBG_NO_LOC("\tdaemonize: %s", config->daemonize ? "True" : "False");<br>
- DBG_NO_LOC("\tsignal parent on start: %s", config->sig_parent ? "True" : "False");<br>
- DBG_NO_LOC("\ttracing group name: %s", config->tracing_group_name.<wbr>value ? : "Unknown");<br>
- DBG_NO_LOC("\tkmod_probe_list: %s", config->kmod_probes_list.value ? : "None");<br>
- DBG_NO_LOC("\tkmod_extra_<wbr>probe_list: %s", config->kmod_extra_probes_<wbr>list.value ? : "None");<br>
- DBG_NO_LOC("\trundir: %s", config->rundir.value ? : "Unknown");<br>
- DBG_NO_LOC("\tapplication socket path: %s", config->apps_unix_sock_path.<wbr>value ? : "Unknown");<br>
- DBG_NO_LOC("\tclient socket path: %s", config->client_unix_sock_path.<wbr>value ? : "Unknown");<br>
- DBG_NO_LOC("\twait shm path: %s", config->wait_shm_path.value ? : "Unknown");<br>
- DBG_NO_LOC("\thealth socket path: %s", config->health_unix_sock_path.<wbr>value ? : "Unknown");<br>
- DBG_NO_LOC("\tLTTNG_UST_CLOCK_<wbr>PLUGIN: %s", config->lttng_ust_clock_<wbr>plugin.value ? : "None");<br>
- DBG_NO_LOC("\tpid file path: %s", config->pid_file_path.value ? : "Unknown");<br>
- DBG_NO_LOC("\tlock file path: %s", config->lock_file_path.value ? : "Unknown");<br>
- DBG_NO_LOC("\tsession load path: %s", config->load_session_path.<wbr>value ? : "None");<br>
- DBG_NO_LOC("\tagent port file path: %s", config->agent_port_file_path.<wbr>value ? : "Unknown");<br>
+ DBG_NO_LOC("\tapplication socket timeout: %i", config->app_socket_timeout);<br>
+ DBG_NO_LOC("\tno-kernel: %s", config->no_kernel ? "True" : "False");<br>
+ DBG_NO_LOC("\tbackground: %s", config->background ? "True" : "False");<br>
+ DBG_NO_LOC("\tdaemonize: %s", config->daemonize ? "True" : "False");<br>
+ DBG_NO_LOC("\tsignal parent on start: %s", config->sig_parent ? "True" : "False");<br>
+ DBG_NO_LOC("\ttracing group name: %s", config->tracing_group_name.<wbr>value ? : "Unknown");<br>
+ DBG_NO_LOC("\tkmod_probe_list: %s", config->kmod_probes_list.value ? : "None");<br>
+ DBG_NO_LOC("\tkmod_extra_<wbr>probe_list: %s", config->kmod_extra_probes_<wbr>list.value ? : "None");<br>
+ DBG_NO_LOC("\trundir: %s", config->rundir.value ? : "Unknown");<br>
+ DBG_NO_LOC("\tapplication socket path: %s", config->apps_unix_sock_path.<wbr>value ? : "Unknown");<br>
+ DBG_NO_LOC("\tclient socket path: %s", config->client_unix_sock_path.<wbr>value ? : "Unknown");<br>
+ DBG_NO_LOC("\twait shm path: %s", config->wait_shm_path.value ? : "Unknown");<br>
+ DBG_NO_LOC("\thealth socket path: %s", config->health_unix_sock_path.<wbr>value ? : "Unknown");<br>
+ DBG_NO_LOC("\tLTTNG_UST_CLOCK_<wbr>PLUGIN: %s", config->lttng_ust_clock_<wbr>plugin.value ? : "None");<br>
+ DBG_NO_LOC("\tpid file path: %s", config->pid_file_path.value ? : "Unknown");<br>
+ DBG_NO_LOC("\tlock file path: %s", config->lock_file_path.value ? : "Unknown");<br>
+ DBG_NO_LOC("\tsession load path: %s", config->load_session_path.<wbr>value ? : "None");<br>
+ DBG_NO_LOC("\tagent port file path: %s", config->agent_port_file_path.<wbr>value ? : "Unknown");<br>
+ DBG_NO_LOC("\tconsumerd32 path: %s", config->consumerd32_path.<wbr>value);<br>
+ DBG_NO_LOC("\tconsumerd32 bin_path: %s", config->consumerd32_bin_path.<wbr>value);<br>
+ DBG_NO_LOC("\tconsumerd32 lib dir: %s", config->consumerd32_lib_dir.<wbr>value);<br>
+ DBG_NO_LOC("\tconsumerd32 err unix sock path:%s", config->consumerd32_err_unix_<wbr>sock_path.value);<br>
+ DBG_NO_LOC("\tconsumerd32 cmd unix sock path:%s", config->consumerd32_cmd_unix_<wbr>sock_path.value);<br>
+ DBG_NO_LOC("\tconsumerd64 path: %s", config->consumerd64_path.<wbr>value);<br>
+ DBG_NO_LOC("\tconsumerd64 bin path: %s", config->consumerd64_bin_path.<wbr>value);<br>
+ DBG_NO_LOC("\tconsumerd64 lib dir: %s", config->consumerd64_lib_dir.<wbr>value);<br>
+ DBG_NO_LOC("\tconsumerd64 err unix sock path:%s", config->consumerd64_err_unix_<wbr>sock_path.value);<br>
+ DBG_NO_LOC("\tconsumerd64 cmd unix sock path:%s", config->consumerd64_cmd_unix_<wbr>sock_path.value);<br>
+ DBG_NO_LOC("\tkconsumerd path: %s", config->kconsumerd_path.value)<wbr>;<br>
+ DBG_NO_LOC("\tkconsumerd err unix sock path: %s", config->kconsumerd_err_unix_<wbr>sock_path.value);<br>
+ DBG_NO_LOC("\tkconsumerd cmd unix sock path: %s", config->kconsumerd_cmd_unix_<wbr>sock_path.value);<br></blockquote><div><br></div><div>Those string values can be NULL. Look at how this is handled for the existing string options (ternary + place holder). In this case, using "Unknown" seems appropriate.</div><div><br></div><div>Thanks,</div><div>Jérémie<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
}<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.0<br>
<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Jérémie Galarneau<br>EfficiOS Inc.<br><a href="http://www.efficios.com" target="_blank">http://www.efficios.com</a></div>
</div></div></div>