<div dir="ltr">Agreed. Let me send this in a final version of this patch.<div><br></div><div>Thanks,</div><div>Francis</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-11-08 16:07 GMT-05:00 Mathieu Desnoyers <span dir="ltr"><<a href="mailto:mathieu.desnoyers@efficios.com" target="_blank">mathieu.desnoyers@efficios.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:arial,helvetica,sans-serif;font-size:12pt;color:#000000"><div><div class="h5"><div><span id="m_-5295043061337586902zwchr">----- On Nov 8, 2016, at 3:46 PM, Francis Deslauriers <<a href="mailto:francis.deslauriers@efficios.com" target="_blank">francis.deslauriers@efficios.<wbr>com</a>> wrote:<br></span></div></div></div><div><div><div class="h5"><blockquote style="border-left:2px solid #1010ff;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2016-11-08 15:06 GMT-05:00 Nathan Lynch <span dir="ltr"><<a href="mailto:Nathan_Lynch@mentor.com" target="_blank">Nathan_Lynch@mentor.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_-5295043061337586902gmail-">On 11/08/2016 01:49 PM, Francis Deslauriers wrote:<br>
> Run a process explicitly in the tracing session to generate the enabled events<br>
> rather than relying on the events generated by the lttng CLI.<br>
<br>
</span>[...]<br><span class="m_-5295043061337586902gmail-"><br>
> diff --git a/tests/regression/kernel/<wbr>test_all_events b/tests/regression/kernel/<wbr>test_all_events<br>
> index 50002f4..80a8020 100755<br>
> --- a/tests/regression/kernel/<wbr>test_all_events<br>
> +++ b/tests/regression/kernel/<wbr>test_all_events<br>
> @@ -21,6 +21,8 @@ CURDIR=$(dirname $0)/<br>
>  TESTDIR=$CURDIR/../..<br>
>  NUM_TESTS=8<br>
><br>
> +TESTCMD="grep -V -q > /dev/null"<br>
> +<br>
<br>
</span>What was wrong with /bin/true, as in v1 of this patch?</blockquote><div>I used grep because the configure script looks for it already</div><div>At the moment, we don't check if /bin/true is installed on the machine using the configure script.<br></div><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
FYI, Busybox grep doesn't know -V:<br><br>
# grep -V -q >/dev/null<br>
grep: invalid option -- 'V'<br>
BusyBox v1.24.1 (2016-11-08 12:59:13 CST) multi-call binary.<br><br>
Usage: grep [-HhnlLoqvsriwFE] [-m N] [-A/B/C N] PATTERN/-e PATTERN.../-f<br>
FILE [FILE]...<br><br>
# echo $?<br>
1<br><br>
It looks like the testcases don't care about the exit status of TESTCMD,<br>
but you may want to redirect stderr to /dev/null as well.<br></blockquote><div>Good point. </div><div>I could do: grep "foo" /dev/null</div></div></div></div></blockquote><div><br></div></div></div><div>utils/utils.sh:45:# We set the default lttng-sessiond path to /bin/true to prevent the spawning<br>utils/utils.sh:49:export LTTNG_SESSIOND_PATH="/bin/<wbr>true"<br><br></div><div>already used.<br></div><div><br></div><div>So unless anyone complain about it, let's use it.<br></div><div><br></div><div>If someone complains, then we need to fix the configure detection.<br></div><div><br></div><div>Thanks,<br></div><div><br></div><div>Mathieu<br></div><span class=""><div><br></div><blockquote style="border-left:2px solid #1010ff;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><br><div>Thank you,</div><div>-- <br><div class="m_-5295043061337586902gmail_signature"><div dir="ltr"><div class="m_-5295043061337586902gmail_signature"><div>Francis Deslauriers</div><div dir="ltr">Software developer<div>EfficiOS inc.</div></div></div></div></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
______________________________<wbr>_________________<br>
lttng-dev mailing list<br><a href="mailto:lttng-dev@lists.lttng.org" target="_blank">lttng-dev@lists.lttng.org</a><br><a href="https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev" rel="noreferrer" target="_blank">https://lists.lttng.org/cgi-<wbr>bin/mailman/listinfo/lttng-dev</a><br></blockquote></div><br><br clear="all"><br><br></div></div><br>______________________________<wbr>_________________<br>lttng-dev mailing list<br><a href="mailto:lttng-dev@lists.lttng.org" target="_blank">lttng-dev@lists.lttng.org</a><br><a href="https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev" target="_blank">https://lists.lttng.org/cgi-<wbr>bin/mailman/listinfo/lttng-dev</a><br></blockquote></span></div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- <br></div><div>Mathieu Desnoyers<br>EfficiOS Inc.<br><a href="http://www.efficios.com" target="_blank">http://www.efficios.com</a></div></font></span></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>Francis Deslauriers</div><div dir="ltr">Software developer<div>EfficiOS inc.</div></div></div></div></div>
</div>