<html><body><div style="font-family: arial, helvetica, sans-serif; font-size: 12pt; color: #000000"><div><br></div><div><br></div><span id="zwchr" data-marker="__DIVIDER__">----- On Jun 22, 2016, at 3:16 PM, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:<br></span><div data-marker="__QUOTED_TEXT__"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div style="font-family: arial, helvetica, sans-serif; font-size: 12pt; color: #000000"><br><br><span id="zwchr">----- On Jun 22, 2016, at 2:17 PM, Luke K D'Alessandro <ldalessa@indiana.edu> wrote:<br></span><div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><br class=""><div><blockquote class=""><div class="">On Jun 22, 2016, at 12:39 PM, Mathieu Desnoyers <<a href="mailto:mathieu.desnoyers@efficios.com" class="" target="_blank">mathieu.desnoyers@efficios.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline"><br class=""></div><span id="zwchr" style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">----- On Jun 22, 2016, at 11:56 AM, Luke K D'Alessandro <<a href="mailto:ldalessa@indiana.edu" class="" target="_blank">ldalessa@indiana.edu</a>> wrote:<br class=""></span><div style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><br class=""><div class=""><blockquote class=""><div class="">On Jun 22, 2016, at 11:37 AM, Mathieu Desnoyers <<a href="mailto:mathieu.desnoyers@efficios.com" class="" target="_blank">mathieu.desnoyers@efficios.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><div class="" style="font-family: arial, helvetica, sans-serif; font-size: 12pt;"><div class=""><span id="zwchr" class="">----- On Jun 14, 2016, at 12:31 PM, Luke K D'Alessandro <<a href="mailto:ldalessa@indiana.edu" class="" target="_blank">ldalessa@indiana.edu</a>> wrote:<br class=""></span></div><div class=""><blockquote class="" style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;"><span class="">I tried following the Darwin instructions on the website (basically `</span><span class="">./configure --build=x86_64-apple-darwin11` but the `clock_gettime` and `-lrt` dependencies don’t exist on Darwin).</span><div class=""><span class=""><br class=""></span></div><div class=""><span class="">Just for fun I removed this dependency and added a custom version of `clock_gettime` (</span><a href="https://github.com/lorrden/darwin-posix-rt/blob/master/clock_gettime.c" class="" target="_blank">https://github.com/lorrden/darwin-posix-rt/blob/master/clock_gettime.c</a>) but the build still fails in `systcall-compat.h`.</div><span class=""><div class=""><span class=""><br class=""></span></div>```<br class=""></span><span class="">$ make V=1<br class="">/Applications/Xcode.app/Contents/Developer/usr/bin/make all-recursive<br class="">Making all in .<br class="">/bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./urcu -I./urcu -Wall -g -O2 -D_THREAD_SAFE -pthread -MT wfqueue.lo -MD -MP -MF .deps/wfqueue.Tpo -c -o wfqueue.lo wfqueue.c<br class="">libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./urcu -I./urcu -Wall -g -O2 -D_THREAD_SAFE -pthread -MT wfqueue.lo -MD -MP -MF .deps/wfqueue.Tpo -c wfqueue.c -fno-common -DPIC -o .libs/wfqueue.o<br class="">In file included from wfqueue.c:28:<br class="">In file included from ./urcu/static/wfqueue.h:33:<br class="">In file included from ./urcu/uatomic.h:24:<br class="">In file included from ./urcu/system.h:23:<br class="">In file included from ./urcu/arch.h:27:<br class="">./urcu/syscall-compat.h:39:2: error: "Add platform support to urcu/syscall-compat.h"<br class="">#error "Add platform support to urcu/syscall-compat.h"<br class=""> ^<br class="">1 error generated.<br class="">make[2]: *** [wfqueue.lo] Error 1<br class="">make[1]: *** [all-recursive] Error 1<br class="">make: *** [all] Error 2<br class=""></span><span class="">```</span><div class=""><span class=""><br class=""></span></div><div class=""><span class="">Is Darwin still a supported platform for the library?</span></div></blockquote><div class=""><br class=""></div><div class="">It should, yes, but we don't test it in our CI yet.<br class=""></div><div class=""><br class=""></div><div class="">I just took care of the syscall-compat.h error (pushed into master</div><div class="">and stable-0.9). For clock_gettime, we would need to implement</div><div class="">a LGPLv2.1 wrapper within liburcu for MacOSX.<br class=""></div><div class=""><br class=""></div><div class="">Is this something you could look into ?<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">Hmm. This isn’t really something I know much about. </div><div class=""><br class=""></div><div class="">The github link I sent seems to be either GPLv2 or LGPLv3… don’t really know what LGPLv2.1 means. Based on the actually code that I’m seeing, there is really not much going on here and thus it might be difficult to do anything differently. It might be easier to have urcu use some configuration time behavior to have its own arch-specific timing functionality if necessary.</div></div></blockquote><div class=""><br class=""></div><div class="">The only place where we need clock_gettime is urcu/arch/generic.h<br class=""></div><div class="">caa_get_cycles.<br class=""></div><div class=""><br class=""></div><div class="">I just pushed the implementation of the fix in master and stable-0.9.<br class=""></div><div class="">Tested on my own macos mini machine. Can you try them out ?<br class=""></div></div></div></blockquote><div><br class=""></div><div>Looks good on my system as well (bootstrapping with current autotools from brew).</div><div><br class=""></div><div>I do get a warning at </div><div><br class=""></div><div>```</div><span class=""> ../../tests/common/thread-id.h:62:3: warning: "use pid as thread ID" [-W#warnings]</span></div><div><span class="">```</span></div></blockquote><br><div>This is just because we don't have a gettid() system call available. This just leads<br></div><div>to less precise debug printout in the test programs, nothing to worry about.<br></div><br><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><span class=""><br class=""></span></div><div><span class="">however `make check` passes. Should Darwin have its own preprocessor branch in this file?</span></div></blockquote><br><div>how about make regtest ?<br></div><br><div>It appears we don't have the "nproc" program available. Is there a brew package for it,<br></div><div>or something similar ?</div></div></div></blockquote><div><br></div><div>This commit now in master and 0.9 should fix it:<br data-mce-bogus="1"></div><div><br data-mce-bogus="1"></div><div><br data-mce-bogus="1"></div><div>commit 2350bf7b3f3c4581493b187988a92b8d871471ba<br>Author: Michael Jeanson <mjeanson@efficios.com><br>Date: Wed Jun 22 15:16:18 2016 -0400<br><br> Fix: Add failover for platforms without nproc<br> <br> Signed-off-by: Michael Jeanson <mjeanson@efficios.com><br> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com><br></div><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div style="font-family: arial, helvetica, sans-serif; font-size: 12pt; color: #000000"><div><div><br></div><br><div>Thanks,<br></div><br><div>Mathieu<br></div><br><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div><span class=""><br class=""></span><div>Thanks for doing this,</div><div>Luke</div><br class=""><blockquote class=""><div class=""><div style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class=""><br class=""></div><div class="">Thanks,<br class=""></div><div class=""><br class=""></div><div class="">Mathieu<br class=""></div><div class=""><br class=""></div><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;" class=""><div class=""><div class=""><br class=""></div><div class="">Luke</div><br class=""><blockquote class=""><div class=""><div class=""><div class="" style="font-family: arial, helvetica, sans-serif; font-size: 12pt;"><div class=""><div class=""><br class=""></div><div class="">Thanks,<br class=""></div><div class=""><br class=""></div><div class="">Mathieu<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><blockquote class="" style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt;"><div class=""><span class=""><br class=""></span></div><div class=""><span class="">Thanks,</span></div><div class=""><span class="">Luke</span></div><br class="">_______________________________________________<br class="">lttng-dev mailing list<br class=""><a href="mailto:lttng-dev@lists.lttng.org" class="" target="_blank">lttng-dev@lists.lttng.org</a><br class=""><a href="https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev" class="" target="_blank">https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev</a><br class=""></blockquote></div><div class=""><br class=""></div><div class="">--<span class="Apple-converted-space"> </span><br class=""></div><div class="">Mathieu Desnoyers<br class="">EfficiOS Inc.<br class=""><a href="http://www.efficios.com/" class="" target="_blank">http://www.efficios.com</a><br class=""></div></div></div></div></blockquote></div><br class=""><br class=""></blockquote></div><br style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">--<span class="Apple-converted-space"> </span><br class=""></div><div style="font-family: arial, helvetica, sans-serif; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Mathieu Desnoyers<br class="">EfficiOS Inc.<br class=""><a href="http://www.efficios.com/" class="" target="_blank">http://www.efficios.com</a><br></div></div></blockquote></div><br class=""><br></blockquote></div><br><div>-- <br></div><div>Mathieu Desnoyers<br>EfficiOS Inc.<br>http://www.efficios.com</div></div><br></blockquote></div><br><div data-marker="__SIG_POST__">-- <br></div><div>Mathieu Desnoyers<br>EfficiOS Inc.<br>http://www.efficios.com</div></div></body></html>