[lttng-dev] lttng-consumerd crash on aarch64 due to x86 arch specific optimization

[Mathieu Desnoyers]

Hi Micke,

I did tweaks to make the code C++ compatible even though it's currently 
only built in C. It makes it more future-proof.

I've merged the resulting patch into lttng-ust 
master/stable-2.13/stable-2.12. Thanks for testing !

Mathieu

On 2023-02-06 11:15, Beckius, Mikael wrote:
> Hello Mathieu!
> 
> I added your latest implementation to my test and it seems to perform well on both arm and arm64. Since the test was written in C++ I had to make a small change to the cast in order for the test to compile.
> 
> Micke
> 
>> -----Ursprungligt meddelande-----
>> Från: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>> Skickat: den 2 februari 2023 17:26
>> Till: Beckius, Mikael <mikael.beckius at windriver.com>; lttng-
>> dev at lists.lttng.org
>> Ämne: Re: [lttng-dev] lttng-consumerd crash on aarch64 due to x86 arch
>> specific optimization
>>
>> CAUTION: This email comes from a non Wind River email account!
>> Do not click links or open attachments unless you recognize the sender and
>> know the content is safe.
>>
>> Hi  Mikael,
>>
>> I just tried another approach to fix this issue, see:
>>
>> https://review.lttng.org/c/lttng-ust/+/9413 Fix: use unaligned pointer
>> accesses for lttng_inline_memcpy
>>
>> It is less intrusive than other approaches, and does not change the generated
>> code on the
>> most relevant architectures.
>>
>> Feedback is welcome,
>>
>> Thanks,
>>
>> Mathieu
>>
>>
>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
>> https://www.efficios.com
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com