[lttng-dev] [PATCH] compaction: make tracepoints condtional on CONFIG_COMPACTION

[Mathieu Desnoyers]

----- On Aug 10, 2022, at 1:48 PM, Bruce Ashfield via lttng-dev lttng-dev at lists.lttng.org wrote:

> On Wed, Aug 10, 2022 at 11:20 AM Michael Jeanson <mjeanson at efficios.com> wrote:
>>
>> On 2022-08-03 15 h 23, Bruce Ashfield via lttng-dev wrote:
>> > Hi all,
>> >
>> > This was found during the update of the yocto project reference
>> > kernel to 5.19. Out of all the supported architectures, only
>> > mips failed during the build of lttng-modules.
>> >
>> > Specifically, it seems like the lack of CONFIG_COMPACTION being
>> > enabled in the kernel was the significant issue. Only one of the
>> > tracepoints blew up, but I can't see how any of them would be
>> > valid in this scenario, or why it would be limited to mips.
>> >
>> > While I don't think this is the right fix, this is what got me
>> > up and passing sanity testing, so I wanted to send the change
>> > and see what the actual, correct fix would be :)
>> >
>> > Cheers,
>> >
>> > Bruce
>>
>> Hi Bruce,
>>
>> Thanks for reporting this issue, I propose a simpler fix [1] of just
>> disabling the build of the compaction probe module when
>> CONFIG_COMPACTION is disabled in the kernel configuration.
>>
>> Can you confirm this patch fixes the issue on your side?
> 
> confirmed, it fixes the issue on my side.

Merged into lttng-modules master, stable-2.13, stable-2.12, thanks!

Mathieu

> 
> Bruce
> 
>>
>> Thanks,
>>
>> Michael
>>
>> [1] https://review.lttng.org/c/lttng-modules/+/8660
> 
> 
> 
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com