[lttng-dev] [PATCH] Avoid using the heap for small strings with tracef/tracelog

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Thu May 20 09:33:38 EDT 2021


----- On May 20, 2021, at 8:20 AM, Norbert Lange nolange79 at gmail.com wrote:

> This patch was intended for 2.12, no src/common/tracer.h there.

You should post feature patches against the master branch. Or if you just
want to send a RFC, and you work on an older branch, please state that the
patch is RFC and which branch the patch is against, but that work won't
be merged unless it's rebased against master.

> Also this patch is brocken, as a va_list cant be iterated twice.

Right. But you could easily do:

va_start() [ first use ] va_end()
then
va_start() [ second use ] va_end(), right ?

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com


More information about the lttng-dev mailing list