[lttng-dev] [PATCH] lttng-ust-common: link with liburcu explicitly

[Jonathan Rajotte-Julien]

Hi Alexander,

Thanks for sending this patch. Could you provide more details regarding the linking errors?

lttng-ust must not depends on liburcu at runtime since commit 10544ee8af31afb239e3dfa71cb2fe09d3de3771

commit 10544ee8af31afb239e3dfa71cb2fe09d3de3771
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date:   Wed Nov 11 17:28:06 2020 -0500

    Remove runtime dependency on liburcu shared objects
    
    Remove the runtime dependency on:
    
    - liblurcu-bp.so
    - liblurcu-cds.so
    - compat futex code.
    
    By integrating those into the lttng-ust project.
    
    For rculfhash, only the minimum pieces needed by lttng-ust are
    integrated (no auto-resize, no accounting).
    
    lttng-ust still requires liburcu at build time for header dependencies.
    
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
    Change-Id: Idffb205b27b1bb0f972523c3ce3bdaf25bfe1710


Cheers 

----- Original Message -----
> From: "Alexander Kanavin" <alex at linutronix.de>
> To: "lttng-dev" <lttng-dev at lists.lttng.org>, "Francis Deslauriers" <francis.deslauriers at efficios.com>, "jonathan
> rajotte-julien" <jonathan.rajotte-julien at efficios.com>
> Cc: "Alexander Kanavin" <alex at linutronix.de>
> Sent: Thursday, December 2, 2021 3:04:12 PM
> Subject: [PATCH] lttng-ust-common: link with liburcu explicitly

> Otherwise linking errors are seen on x86-32.
> ---
> src/lib/lttng-ust-common/Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/src/lib/lttng-ust-common/Makefile.am
> b/src/lib/lttng-ust-common/Makefile.am
> index caeea2be..0130628c 100644
> --- a/src/lib/lttng-ust-common/Makefile.am
> +++ b/src/lib/lttng-ust-common/Makefile.am
> @@ -15,6 +15,7 @@ liblttng_ust_common_la_SOURCES = \
> 
> liblttng_ust_common_la_LIBADD = \
> 	$(top_builddir)/src/common/libcommon.la \
> +	$(URCU_LIBS) \
> 	$(DL_LIBS)
> 
> liblttng_ust_common_la_LDFLAGS = -no-undefined -version-info
> $(LTTNG_UST_LIBRARY_VERSION)
> --
> 2.20.1