[lttng-dev] [lttng-ust] duplicated struct ustctl_consumer_channel_attr

[Sebastien Boisvert]

Hello,

As suggested by Jonathan [1], I should start a new email thread.

Why are there 2 identical declarations of struct ustctl_consumer_channel_attr
(one in lttng-ust, one in lttng-tools) instead of just one ?

It just seems redundant to me.


[sboisvert at GT480:lttng-ust]$ grep "struct ustctl_consumer_channel_attr {" -A 11 include/lttng/ust-ctl.h
struct ustctl_consumer_channel_attr {
	enum lttng_ust_chan_type type;
	uint64_t subbuf_size;			/* bytes */
	uint64_t num_subbuf;			/* power of 2 */
	int overwrite;				/* 1: overwrite, 0: discard */
	unsigned int switch_timer_interval;	/* usec */
	unsigned int read_timer_interval;	/* usec */
	enum lttng_ust_output output;		/* splice, mmap */
	uint32_t chan_id;			/* channel ID */
	unsigned char uuid[LTTNG_UST_UUID_LEN]; /* Trace session unique ID */
	int64_t blocking_timeout;			/* Blocking timeout (usec) */
} LTTNG_PACKED;


[sboisvert at GT480:lttng-tools]$ grep "struct ustctl_consumer_channel_attr {" -A 11 src/bin/lttng-sessiond/lttng-ust-ctl.h
struct ustctl_consumer_channel_attr {
	enum lttng_ust_chan_type type;
	uint64_t subbuf_size;			/* bytes */
	uint64_t num_subbuf;			/* power of 2 */
	int overwrite;				/* 1: overwrite, 0: discard */
	unsigned int switch_timer_interval;	/* usec */
	unsigned int read_timer_interval;	/* usec */
	enum lttng_ust_output output;		/* splice, mmap */
	uint32_t chan_id;			/* channel ID */
	unsigned char uuid[LTTNG_UST_UUID_LEN]; /* Trace session unique ID */
	int64_t blocking_timeout;			/* Blocking timeout (usec) */
} LTTNG_PACKED;


----
[1] https://lists.lttng.org/pipermail/lttng-dev/2019-May/028894.html