[lttng-dev] [RFC PATCH lttng-tools v2 00/20] Improvements in sessiond-comm
Yannick Lamarre
ylamarre at efficios.com
Wed May 1 15:34:24 EDT 2019
Here's a broad description of changes from v1:
1) Removed mentions of big endian storage in jgalar patch since they're
obsolete
2) Changed commit titles to specify targeted structs
3) Fixed reported spelling errors
4) Added missing asserts in serdes functions
5) Fixed reported coding style issues
6) Document for inter-process comm requirements added
(RFC on how this should be structured)
7) Rephrased some commit messages (pointers and padding removal)
8) Replaced awkward if/else if/else code structure by switch for lttng_event
serialization
See individual patches for additionnal comments.
Jérémie Galarneau (1):
Fix: Use platform-independant types in sessiond to consumerd
communication
Yannick Lamarre (19):
Clean-up: Switch enum fields in lttcomm_consumer_msg
Clean-up: Switch enum fields in lttcomm_consumer_status_msg
Clean-up: Switch enum fields in lttcomm_consumer_status_channel
Clean-up: Remove unused structure
Clean-up: Removed deprecated field
Document inter-proccesses communication protocols requirements
Add serialized versions of lttng_channel structs
Add serdes functions for lttng_channel
Integrate serialized communication for lttng_channel
Add serialized versions of lttng_event_context structs
Add serdes functions for lttng_event_context
Integrate serialized communication for lttng_event_context
Add serialized versions of lttng_event structs
Add serdes functions for lttng_event
Integrate serialized communication for lttng_event
Add serialized versions of lttng_snapshot_output structs
Add serdes functions for lttng_snapshot_output
Integrate serialized communication for lttng_snapshot_output
Introduce serialization unit test
.gitignore | 1 +
doc/comm-requirements.txt | 9 +
include/lttng/channel-internal.h | 35 ++
include/lttng/event-internal.h | 59 +++
include/lttng/snapshot-internal.h | 12 +
src/bin/lttng-sessiond/client.c | 93 +++-
src/bin/lttng-sessiond/consumer.c | 5 +-
src/common/kernel-consumer/kernel-consumer.c | 11 +-
src/common/sessiond-comm/sessiond-comm.c | 490 +++++++++++++++++++++
src/common/sessiond-comm/sessiond-comm.h | 149 +++++--
src/common/ust-consumer/ust-consumer.c | 11 +-
src/lib/lttng-ctl/lttng-ctl.c | 57 +--
src/lib/lttng-ctl/snapshot.c | 26 +-
tests/regression/tools/live/Makefile.am | 2 +-
tests/unit/Makefile.am | 14 +-
.../unit/test_utils_sessiond_comm_serialization.c | 290 ++++++++++++
16 files changed, 1165 insertions(+), 99 deletions(-)
create mode 100644 doc/comm-requirements.txt
create mode 100644 tests/unit/test_utils_sessiond_comm_serialization.c
--
2.11.0
More information about the lttng-dev
mailing list