[lttng-dev] [PATCH lttng-tools 3/8] Change LTTNG_POLL_GETNB behaviour for poll flavor

Yannick Lamarre ylamarre at efficios.com
Tue Mar 19 17:17:30 EDT 2019


LTTNG_POLL_GETNB was modified to provide compatibility with the epoll
flavor. Since it is only used after a lttng_poll_wait call with no
modification (add, del, mod) between, this change does not modify the
behaviour in its current usage while still providing test compatibility.

Signed-off-by: Yannick Lamarre <ylamarre at efficios.com>
---
 src/common/compat/poll.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/common/compat/poll.h b/src/common/compat/poll.h
index fde54ddb..7dd8741b 100644
--- a/src/common/compat/poll.h
+++ b/src/common/compat/poll.h
@@ -315,10 +315,14 @@ static inline int __lttng_poll_get_prev_fd(struct lttng_poll_event *events,
 /*
  * For the following calls, consider 'e' to be a lttng_poll_event pointer and i
  * being the index of the events array.
+ * LTTNG_POLL_GETNB was modified to provide compatibility with the epoll
+ * flavor. Since it is only used after a lttng_poll_wait call with no
+ * modification (add, del, mod) between, this change does not modify the
+ * behaviour in its current usage while still providing test compatibility.
  */
 #define LTTNG_POLL_GETFD(e, i) LTTNG_REF(e)->wait.events[i].fd
 #define LTTNG_POLL_GETEV(e, i) LTTNG_REF(e)->wait.events[i].revents
-#define LTTNG_POLL_GETNB(e) LTTNG_REF(e)->wait.nb_fd
+#define LTTNG_POLL_GETNB(e) LTTNG_REF(e)->current.nb_fd
 #define LTTNG_POLL_GETSZ(e) LTTNG_REF(e)->wait.events_size
 #define LTTNG_POLL_GET_PREV_FD(e, i, nb_fd) \
 	__lttng_poll_get_prev_fd(LTTNG_REF(e), i, nb_fd)
-- 
2.11.0



More information about the lttng-dev mailing list