[lttng-dev] [PATCH lttng-ust] Use MAP_POPULATE to reduce pagefault when available

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Mon Jul 29 14:44:36 EDT 2019


----- On Jul 29, 2019, at 2:41 PM, Sebastien Boisvert sboisvert at gydle.com wrote:

> nits:
> 
> On 2019-07-29 2:32 p.m., Mathieu Desnoyers wrote:
>>> A similar flag seems to exists on freebsd (MAP_PREFAULT_READ) but I do
>> 
>> exists -> exit
> 
> exist ?

Indeed :)

> 
> 
>>> [1] https://lists.lttng.org/pipermail/lttng-dev/2019-July/029122.html
>>>
>>> Tested-by: Yiteng Guo <guoyiteng at gmail.com> [1]
>> 
>> I think you might want to add a # before [1] so automated tools don't
>> get confused here. But even better, just describe it has been tested
>> above in the commit message.
> 
> The "Link:" tag can be used for that.

Yes, good point!

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com


More information about the lttng-dev mailing list