[lttng-dev] [PATCH lttng-tools 1/2] Fix: Connect timeout arithmetic in inet/inet6 (v2)

[Mathieu Desnoyers]

----- On Nov 10, 2018, at 9:20 AM, Mathieu Desnoyers mathieu.desnoyers at efficios.com wrote:

> ----- On Nov 9, 2018, at 6:13 PM, Jonathan Rajotte
> jonathan.rajotte-julien at efficios.com wrote:
> 
>> As discussed on IRC, could you make sure to test it manually at least once since
>> the problematic scenario is never tested by regression test.
>> Looks much better than my first attempt but we never know.
>> 
>> You can force delay locally using tc.
>> 
>> Something like:
>> 
>>    LTTNG_NETWORK_SOCKET_TIMEOUT=4000 lttng-sessiond -b -vvv
>>    lttng-relayd -b
>>    lttng create --live
>>    sudo tc qdisc add dev lo root netem delay 10000ms
>>    lttng enable-event -u -a
>>    #Should see errors of connection timeout taking around 4 secs, validate using
>>    #the logs.
>> 
>>    sudo tc qdisc del dev lo root netem delay 10000ms
>> 
>> You can also do the opposite for delays to validate working connect that take a
>> long time.
> 
> Let's test it on Monday. Meanwhile I'll send an updated version taking your
> comments into account.
> 

It seems to work fine with my patch applied.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com