[lttng-dev] [PATCH] Fix: do not use CONFIG_HOTPLUG_CPU for the new hotplug API

Lars Persson lars.persson at axis.com
Sun Mar 11 10:02:43 EDT 2018


Kernel configurations without CONFIG_HOTPLUG_CPU throw an unknown
symbol error when attempting to insert the lttng-trace module:
 lttng_tracer: Unknown symbol lttng_hp_prepare (err 0)
 lttng_tracer: Unknown symbol lttng_hp_online (err 0)

This was caused by lttng-events and lttng-context-perf-counter not
agreeing on which preprocessor condition that should guard the use of
the hotplug API. In fact the API is available also on kernels built
without CONFIG_HOTPLUG_API.

Signed-off-by: Lars Persson <larper at axis.com>
---
 lttng-events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lttng-events.c b/lttng-events.c
index 6f122dd..2cd650f 100644
--- a/lttng-events.c
+++ b/lttng-events.c
@@ -2644,7 +2644,7 @@ void lttng_transport_unregister(struct lttng_transport *transport)
 }
 EXPORT_SYMBOL_GPL(lttng_transport_unregister);
 
-#if (defined(CONFIG_HOTPLUG_CPU) && (LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0)))
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0))
 
 enum cpuhp_state lttng_hp_prepare;
 enum cpuhp_state lttng_hp_online;
-- 
2.11.0



More information about the lttng-dev mailing list