[lttng-dev] [PATCH urcu 3/4] [RFC] Fix: don't wait after completion of a work queue job batch

Jérémie Galarneau jeremie.galarneau at efficios.com
Fri Dec 7 17:06:38 EST 2018


As indicated in the previous patch of this series, waiting on
completion of a job batch from the work queue artificially increases
the latency of the work queue.

The previous patch removed the wait that is performed when the
work queue is observed to be empty and was observed as the cause of a
performance problem.

It is likely that waiting when the queue is observed to be non-empty
is similarly unintended. Note that I have not observed such a problem
myself.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau at efficios.com>
---
 src/workqueue.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/workqueue.c b/src/workqueue.c
index d609006..6822314 100644
--- a/src/workqueue.c
+++ b/src/workqueue.c
@@ -246,8 +246,6 @@ static void *workqueue_thread(void *arg)
 				 * call_rcu list.
 				 */
 				cmm_smp_mb();
-			} else {
-				(void) poll(NULL, 0, 10);
 			}
 		} else {
 			(void) poll(NULL, 0, 10);
-- 
2.19.2



More information about the lttng-dev mailing list