[lttng-dev] [PATCH v2 lttng-tools master, 2.10-rc] Introduce "--blocking-timeout" channel parameter

[Mathieu Desnoyers]

----- On Jun 12, 2017, at 5:28 PM, Jeremie Galarneau jeremie.galarneau at efficios.com wrote:


>>
>> +       /* Retry timeout in usec */
> 
> The unit conversion is confusing in this patch.
> 
> The user-provided (CLI) argument is in usec and is then converted to
> msec by the client, before being used as msec with liblttng-ctl
> functions. Then, it is retrieved and output as-is (in msec) here and
> in the human-readable listing.
> 
> I'll move the unit conversion to a single place (before we hand-off
> the delay to lttng-ust) since the current convention is to store and
> expose all timers in usec.
> 

As discussed, the CLI only does an overflow check, not a conversion.
Let's simply add this overflow check in the lib too, so we can
return "invalid parameter" to the caller.

> I'll also open an issue to add this property as part of the
> "save/load" functionality before the realease.

OK,

Thanks!

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com