[lttng-dev] [PATCH lttng-tools v2] Fix: test cases now rely on explicit workloads
Nathan Lynch
Nathan_Lynch at mentor.com
Tue Nov 8 20:06:53 UTC 2016
On 11/08/2016 01:49 PM, Francis Deslauriers wrote:
> Run a process explicitly in the tracing session to generate the enabled events
> rather than relying on the events generated by the lttng CLI.
[...]
> diff --git a/tests/regression/kernel/test_all_events b/tests/regression/kernel/test_all_events
> index 50002f4..80a8020 100755
> --- a/tests/regression/kernel/test_all_events
> +++ b/tests/regression/kernel/test_all_events
> @@ -21,6 +21,8 @@ CURDIR=$(dirname $0)/
> TESTDIR=$CURDIR/../..
> NUM_TESTS=8
>
> +TESTCMD="grep -V -q > /dev/null"
> +
What was wrong with /bin/true, as in v1 of this patch?
FYI, Busybox grep doesn't know -V:
# grep -V -q >/dev/null
grep: invalid option -- 'V'
BusyBox v1.24.1 (2016-11-08 12:59:13 CST) multi-call binary.
Usage: grep [-HhnlLoqvsriwFE] [-m N] [-A/B/C N] PATTERN/-e PATTERN.../-f
FILE [FILE]...
# echo $?
1
It looks like the testcases don't care about the exit status of TESTCMD,
but you may want to redirect stderr to /dev/null as well.
More information about the lttng-dev
mailing list