[lttng-dev] [PATCH lttng-tools] Fix: unchecked return value in low throughput test

Jérémie Galarneau jeremie.galarneau at efficios.com
Wed May 18 20:07:35 UTC 2016


Merged, thanks!

Jérérmie

On Tue, May 17, 2016 at 12:22 PM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> Found by Coverity:
>
> CID 1019967 (#1 of 1): Unchecked return value from library
> (CHECKED_RETURN)2. check_return: Calling poll(NULL, 0UL, 60000) without
> checking return value. This library function may fail and return an
> error code.
>
> We really don't care whether this poll succeeds or not.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  tests/regression/ust/low-throughput/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/regression/ust/low-throughput/main.c b/tests/regression/ust/low-throughput/main.c
> index 06ab9ef..b1c38bc 100644
> --- a/tests/regression/ust/low-throughput/main.c
> +++ b/tests/regression/ust/low-throughput/main.c
> @@ -34,7 +34,7 @@ static void *th_event_minute(void *data)
>         /* Loop for 20 minutes */
>         for (i = 1; i < 21; i++) {
>                 /* Sleep 60 seconds */
> -               poll(NULL, 0, 60000);
> +               (void) poll(NULL, 0, 60000);
>
>                 /* 20 minutes tracepoint */
>                 if ((i % 20) == 0) {
> --
> 2.1.4
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com


More information about the lttng-dev mailing list