[lttng-dev] [PATCH lttng-tools] Fix: unchecked return value in relayd live.c
Mathieu Desnoyers
mathieu.desnoyers at efficios.com
Tue May 17 16:13:13 UTC 2016
CID 1323137 (#1 of 1): Unchecked return value (CHECKED_RETURN)30.
check_return: Calling viewer_stream_get without checking return value
(as is done elsewhere 5 out of 6 times).
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
---
src/bin/lttng-relayd/live.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c
index 82bd2bd..0a66405 100644
--- a/src/bin/lttng-relayd/live.c
+++ b/src/bin/lttng-relayd/live.c
@@ -339,7 +339,10 @@ int make_viewer_streams(struct relay_session *session,
* Ensure a self-reference is preserved even
* after we have put our local reference.
*/
- viewer_stream_get(vstream);
+ if (!viewer_stream_get(vstream)) {
+ ERR("Unable to get self-reference on viewer stream, logic error.");
+ abort();
+ }
} else {
if (!vstream->sent_flag && nb_unsent) {
/* Update number of unsent stream counter. */
--
2.1.4
More information about the lttng-dev
mailing list