[lttng-dev] [PATCH lttng-tools] Fix: macro compares unsigned to 0 (no effect)

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Tue May 17 13:01:51 UTC 2016


Found by Coverity:

CID 1262117 (#1 of 1): Macro compares unsigned to 0
(NO_EFFECT)unsigned_compare: This greater-than-or-equal-to-zero
comparison of an unsigned value is always true. events->nb_fd >= 0U.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
---
 src/common/compat/compat-epoll.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/common/compat/compat-epoll.c b/src/common/compat/compat-epoll.c
index 58f50cc..6259fd3 100644
--- a/src/common/compat/compat-epoll.c
+++ b/src/common/compat/compat-epoll.c
@@ -208,7 +208,6 @@ int compat_epoll_wait(struct lttng_poll_event *events, int timeout)
 		ERR("Wrong arguments in compat_epoll_wait");
 		goto error;
 	}
-	assert(events->nb_fd >= 0);
 
 	if (events->nb_fd == 0) {
 		errno = EINVAL;
-- 
2.1.4



More information about the lttng-dev mailing list