[lttng-dev] [PATCH babeltrace] Don't use the .so extension on test assets

Simon Marchi simark at simark.ca
Wed May 4 17:18:46 UTC 2016


On 2016-05-04 13:15, Michael Jeanson wrote:
> ----- On May 4, 2016, at 1:12 PM, Simon Marchi simark at simark.ca wrote:
> 
>> On 2016-05-04 12:25, Michael Jeanson wrote:
>>> Some packaging system like dpkg-source in native mode
>>> used by our daily build system will filter out files
>>> considered unclean prior to the build. This behavior
>>> results in our test assets being deleted and the
>>> subsequent fails the make check.
>>> 
>>> Since we do not require the .so extension and these files
>>> should be treated as blobs, rename them to "_so".
>>> 
>>> Signed-off-by: Michael Jeanson <mjeanson at efficios.com>
>> 
>> +1.
>> 
>> Since it looks strange, maybe a comment in the README explaining why
>> they are named like this would be good?
> 
> Updated patch is welcome :)

Ok I understand, I'll stop trying to give constructive comments :).


More information about the lttng-dev mailing list