[lttng-dev] [PATCH babeltrace] configure: fix uuid support detection on static build

[Jérémie Galarneau]

Merged in master and stable-1.4, thanks!

Jérémie

On Sun, Jun 26, 2016 at 12:26 PM, Samuel Martin <s.martin49 at gmail.com> wrote:
> Hi Jérémie,
>
> On Tue, Jun 14, 2016 at 8:21 AM, Samuel Martin <s.martin49 at gmail.com> wrote:
>> Hi Jérémie,
>>
>> On Tue, Jun 14, 2016 at 1:21 AM, Jérémie Galarneau
>> <jeremie.galarneau at efficios.com> wrote:
>>> On Wed, Jun 1, 2016 at 3:56 PM, Samuel Martin <s.martin49 at gmail.com> wrote:
>>>> This change adds uuid detection using pkg-config helper before falling
>>>> back on the standard AC_CHECK_LIB detection for platforms missing
>>>> pkg-config.
>>>>
>>>> AC_CHECK_LIB function achieves its test by trying to link against the
>>>> requested library, without taking care of its dependency
>>>> requirements/flags that may differ between different targets.
>>>> Therefore, in case of static build, it can fail on the uuid detection
>>>> like [1], because the uuid's dependency flags (regarding gettext) are
>>>> missing.
>>>
>>> Hi Samuel,
>>>
>>> The same requirements seem to exist for glib (gettext), does the
>>> change need to be made for it also?
>> Maybe, I did not trigger this in my test (certainly because fix the
>> first error was enough to provide all deps the others need...)
>> I'll check it and report back here.
>
> Sorry for being so long :-/
>
> AFAICS, the glib dependency is already correctly handle since it
> already and unconditionally uses PKG_CHECK_MODULES to set its LIBS and
> CFLAGS variables [1]; so, the gettext/libintl dependency flags are
> already and properly set when it is needed.
>
> [1] http://git.efficios.com/?p=babeltrace.git;a=blob;f=configure.ac;h=84f9000d83324ed098980f250632d566f42b1701;hb=HEAD#l303
>
> BR,
>
> --
> Samuel



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com