[lttng-dev] lttng-modules 2.6.1 compilation error on Ubuntu 14.04

[Mathieu Desnoyers]

It is pushed into master and stable-2.6 as we speak, so you 
can try it out. 

Thanks! 

Mathieu 

----- Original Message -----

> Thanks Mathieu! In the meantime I'm using 2.6.0 for the moment and will try
> your fix when it's ready.

> On Thu, May 14, 2015 at 11:28 AM, Mathieu Desnoyers <
> mathieu.desnoyers at efficios.com > wrote:

> > ----- Original Message -----
> 
> > > ----- Original Message -----
> 
> > >
> 
> > > > Hello there. I was wondering if anybody knew what is causing this
> 
> > > > compilation
> 
> > > > error I'm getting on a new Ubuntu 14.04 VM with a 3.13.0 kernel. It
> > > > does
> 
> > > > not
> 
> > > > find the DEBIAN_API_VERSION symbol. The use of that was introduced in
> > > > 2.6.1
> 
> > > > apparently:
> 
> > >
> 
> > > > http://fossies.org/diffs/lttng-modules/2.6.0_vs_2.6.1/lttng-kernel-version.h-diff.html
> 
> > >
> 
> > > > I'm following the instructions in the Download page to install from the
> > > > PPA
> 
> > > > :
> 
> > > > http://lttng.org/download/#ubuntu
> 
> > >
> 
> > > > This the error I'm getting. Thanks in advance for any help!
> 
> > >
> 
> > > > In file included from
> 
> > > > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+201504291801~ubuntu14.04.1/build/wrapper/page_alloc.h:28:0,
> 
> > > > from
> 
> > > > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+201504291801~ubuntu14.04.1/build/lttng-events.c:27:
> 
> > > > /var/lib/dkms/lttng-modules/2.6.x+stable+bzr727+pack22+201504291801~ubuntu14.04.1/build/wrapper/../lttng-kernel-version.h:60:57:
> 
> > > > error: operator '+' has no right operand ((LINUX_VERSION_CODE *
> 
> > > > 1000000ULL)
> 
> > > > + DEBIAN_API_VERSION)
> 
> > >
> 
> > > I pushed the following fix into master and stable-2.6 branches
> 
> > > of lttng-modules. Can you give it a try ?
> 
> > >
> 
> > > commit a748963b76f353d459a3faf85eecc96f52811eee
> 
> > > Author: Mathieu Desnoyers < mathieu.desnoyers at efficios.com >
> 
> > > Date: Thu May 14 09:13:49 2015 -0400
> 
> > >
> 
> > > Fix: build against Ubuntu kernels
> 
> > >
> 
> > > Recent Ubuntu kernels appear to define DEBIAN_API_VERSION, but they are
> 
> > > not really a Debian kernel per-se: the abi-debian-version.sh cannot find
> 
> > > the expected Debian kernel version string layout.
> 
> > >
> 
> > > Therefore, change the conditional check to use directly the
> 
> > > LTTNG_DEBIAN_VERSION_CODE define, which is defined only when the
> 
> > > abi-debian-version.sh script figures out it builds against a Debian
> 
> > > kernel.
> 
> > >
> 
> > > Signed-off-by: Mathieu Desnoyers < mathieu.desnoyers at efficios.com >
> 

> > I reverted this commit. DEBIAN_API_VERSION is actually
> 
> > the define I use to communicate between the makefile
> 
> > and the C code. It should work even if not defined
> 
> > (see the check in LTTNG_DEBIAN_KERNEL_RANGE()).
> 

> > Hrm. But it appears that the operators generated by
> 
> > those macros end up being invalid if DEBIAN_API_VERSION
> 
> > is undefined. Will fix and push upstream.
> 

> > Thanks,
> 

> > Mathieu
> 

> > >
> 
> > > Thanks,
> 
> > >
> 
> > > Mathieu
> 
> > >
> 
> > > > _______________________________________________
> 
> > > > lttng-dev mailing list
> 
> > > > lttng-dev at lists.lttng.org
> 
> > > > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 
> > >
> 
> > > --
> 
> > >
> 
> > > --
> 
> > > Mathieu Desnoyers
> 
> > > EfficiOS Inc.
> 
> > > http://www.efficios.com
> 
> > >
> 
> > > _______________________________________________
> 
> > > lttng-dev mailing list
> 
> > > lttng-dev at lists.lttng.org
> 
> > > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 
> > >
> 

> > --
> 
> > Mathieu Desnoyers
> 
> > EfficiOS Inc.
> 
> > http://www.efficios.com
> 

-- 
Mathieu Desnoyers 
EfficiOS Inc. 
http://www.efficios.com 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20150514/73ad8333/attachment.html>