[lttng-dev] [BUG] lttng-sessiond

[Jérémie Galarneau]

Hi Hannes,

Thanks for reporting this issue! Philippe has submitted two patches which
are now merged in both master and stable-2.6 [1][2].

Let us know if the problem persists,
Jérémie

[1]
https://github.com/lttng/lttng-tools/commit/9ae17e21d5de3a709182f11eaba3ba175ee0c432
[2]
https://github.com/lttng/lttng-tools/commit/44603c80f2e1ce55b6237a02810de8e7fc1687d4


On Sat, Apr 25, 2015 at 10:37 AM, Hannes Weisbach <
hannes.weisbach at mailbox.tu-dresden.de> wrote:

> >
> > Why do you need to load those explicitly ? They should be
> > already loaded by default. I don't get those errors here.
> > Which shell are you using (sh symlink) ? Can you reproduce
> > using bash ?
> Ok.  Found the bug.  In append_list_to_probes() index is used to get
> the current index into the probes array.  However in the loop, index
> is never incremented.  Therefore, the first entry of probes is
> overwritten, but nr_probes is incremented, and later those "empty"
> entries are referenced.
>
> There is also a memory leak in append_list_to_probes():
>
> tmp_list = strdup(list); // uses malloc()
> next = strtok(tmp_list, ","); // tmp_list needs to be NULL except in the
> first iteration
> tmp_list = NULL; // so set it NULL
> free(tmp_list); // good intention, does not work.
>
> Best regards,
> Hannes
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
>


-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20150506/e638f642/attachment.html>